mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Centralize bounded Guardian review evidence in guardian-context (#43595)
## What changed Move prior-review rendering and developer-message construction into `codex_guardian_context`, and route async scorer evidence through a dedicated `PreviousReviews` context section. Validate a maximum of eight review fragments and a per-fragment byte budget equivalent to 1,000 approximate tokens. Reject oversized evidence without rewriting or dropping records, and fail closed when validation fails. Preserve authorization-version filtering and the existing developer-role delivery. Keep review contents out of debug output. ## Testing Add coverage for count and UTF-8 byte-size boundaries, preservation of accepted fragments, async-only section delivery, and omission of review contents from debug output. GitOrigin-RevId: 05e9f53a6405f490b2424b2491a834cd90ab24f0
This commit is contained in:
1 parent
a444546564
commit
0b9b5ecff3
17 files changed
+334
-129
No files matched your search
@@ -248,6 +248,7 @@ pub(crate) async fn build_guardian_prompt_items_with_parent_turn(
|
||||
push_text(text);
|
||||
}
|
||||
}
|
||||
ContextSection::PreviousReviews(_) => unreachable!("prior reviews are async-only"),
|
||||
ContextSection::ConversationTranscript { .. } => {}
|
||||
ContextSection::PermissionContext { items } => permission_items = items,
|
||||
ContextSection::PlannedAction(action) => {
|
||||
@@ -480,6 +481,7 @@ pub(super) fn collect_guardian_context(
|
||||
trusted_user_answers,
|
||||
planned_action,
|
||||
permissions,
|
||||
previous_reviews: None,
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user