mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Enforce automatic review for managed models (#37511)
## What changed - Add the managed `auto_review.required_on_models` requirement, unioning model slugs across requirement layers and exposing the result through `configRequirements/read`. - Force listed models to use `on-request` approvals with the `auto_review` reviewer. Downgrade Full Access to workspace-write when starting a protected session, and reject incompatible runtime overrides or use when automatic review is disabled. - Preserve these protections across thread starts, resumes, forks, model changes, turn overrides, MCP approvals, and TUI session attachment. ## Testing - Add coverage for layered model requirements and exact provider-alias matching. - Add app-server tests for protected thread lifecycle operations, unsafe setting overrides, legacy thread upgrades, disabled automatic review, and requirements API output. GitOrigin-RevId: c4b1d52c3b5b75e86880725412b8f0812e0dfcd9
This commit is contained in:
1 parent
8073dbb20b
commit
208f05b233
37 files changed
+944
-36
No files matched your search
@@ -1293,6 +1293,7 @@ async fn maybe_request_mcp_tool_approval(
|
||||
let approvals_reviewer = connectors::mcp_approvals_reviewer_from_layers(
|
||||
&config.config_layer_stack,
|
||||
config.approvals_reviewer,
|
||||
Some(turn_context.model_info.slug.as_str()),
|
||||
&invocation.server,
|
||||
metadata.connector_id.as_deref(),
|
||||
);
|
||||
@@ -1455,6 +1456,7 @@ pub(crate) fn mcp_approvals_reviewer(
|
||||
) -> ApprovalsReviewer {
|
||||
connectors::mcp_approvals_reviewer(
|
||||
turn_context.config.as_ref(),
|
||||
Some(turn_context.model_info.slug.as_str()),
|
||||
server_name,
|
||||
metadata.and_then(|metadata| metadata.connector_id.as_deref()),
|
||||
)
|
||||
|
||||
Reference in new issue
Block a user