mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Honor null thread instructions (#16964)
- Treat explicit null thread instructions as a blank-slate override while preserving omitted-field fallback behavior. - Preserve null through rollout resume/fork and keep explicit empty strings distinct. - Add app-server v2 start/fork coverage for the tri-state instruction params.
This commit is contained in:
1 parent
4bb507d2c4
commit
24c598e8a9
39 files changed
+550
-101
No files matched your search
@@ -977,7 +977,7 @@ async fn test_get_thread_contents() {
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn test_base_instructions_missing_in_meta_defaults_to_null() {
|
||||
async fn test_base_instructions_missing_in_meta_stays_missing() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let home = temp.path();
|
||||
|
||||
@@ -1011,10 +1011,7 @@ async fn test_base_instructions_missing_in_meta_defaults_to_null() {
|
||||
.await
|
||||
.expect("session meta head");
|
||||
let first = head.first().expect("first head entry");
|
||||
assert_eq!(
|
||||
first.get("base_instructions"),
|
||||
Some(&serde_json::Value::Null)
|
||||
);
|
||||
assert_eq!(first.get("base_instructions"), None);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
|
||||
Reference in new issue
Block a user