mirror of
https://github.com/openai/codex.git
synced 2026-11-17 14:58:36 +00:00
Bind MCP OAuth refresh tokens to their issuer (#39615)
## Why An authorization server discovered for an MCP server can change. A stored refresh token must not be sent to a different issuer than the one that originally granted it. ## What changed - Persist the discovered authorization server issuer with new OAuth credentials and preserve it across refreshes. - Validate that issuer against a single pinned metadata snapshot before refreshing or adopting stored refresh credentials. - Require reauthentication when refresh credentials have no issuer or the issuer changed. An unexpired access token can still be used without exposing its refresh token. ## Testing Add coverage for issuer persistence, missing and changed issuers, metadata changes during startup, and refresh-token preservation. GitOrigin-RevId: 07e48ba892f627428a28bbed5cca4ad703e2a5fd
This commit is contained in:
1 parent
530c1aed58
commit
250b5ea2bf
16 files changed
+722
-110
No files matched your search
@@ -35,7 +35,8 @@ impl RmcpClient {
|
||||
let should_retry = match &initial_transport {
|
||||
PendingTransport::InProcess { .. } | PendingTransport::Stdio { .. } => false,
|
||||
PendingTransport::StreamableHttp { .. }
|
||||
| PendingTransport::StreamableHttpWithOAuth { .. } => true,
|
||||
| PendingTransport::StreamableHttpWithOAuth { .. }
|
||||
| PendingTransport::StreamableHttpWithAccessTokenOnly { .. } => true,
|
||||
};
|
||||
let mut retry_deadline = timeout.map(|duration| Instant::now() + duration);
|
||||
let mut pending_transport = Some(initial_transport);
|
||||
|
||||
Reference in new issue
Block a user