mirror of
https://github.com/openai/codex.git
synced 2026-11-20 23:08:21 +00:00
Add shared runtime build information (#37929)
## What changed - Add `codex-build-info` to resolve a packaged runtime's semantic version from `codex-package.json` while preserving the commit stamped into the executable. - Represent source builds as version `0.0.0` and expose helpers for display, serialization, and source-build detection. - Stamp `STABLE_GIT_COMMIT` into final Bazel Rust binaries so Git changes do not invalidate the shared library graph. ## Testing - Cover packaged, source, legacy, and invalid-version resolution, plus serialization round trips. GitOrigin-RevId: 669b02449644c738ba2946a1b7aafe4ec31a9edb
This commit is contained in:
1 parent
722784e936
commit
2cc9dbb984
7 files changed
+302
-1
No files matched your search
@@ -0,0 +1,133 @@
|
||||
use std::fs;
|
||||
|
||||
use codex_install_context::InstallContext;
|
||||
use pretty_assertions::assert_eq;
|
||||
use semver::Version;
|
||||
use tempfile::tempdir;
|
||||
|
||||
use crate::BuildInfo;
|
||||
|
||||
const BUILD_COMMIT: &str = "0123456789abcdef0123456789abcdef01234567";
|
||||
|
||||
/// A packaged runtime takes its release identity from its package manifest.
|
||||
#[test]
|
||||
fn packaged_runtime_uses_manifest_version() {
|
||||
let package = tempdir().expect("create runtime package");
|
||||
let bin_dir = package.path().join("bin");
|
||||
fs::create_dir(&bin_dir).expect("create runtime binary directory");
|
||||
let executable = bin_dir.join("codex");
|
||||
fs::write(&executable, b"").expect("create runtime binary");
|
||||
fs::write(
|
||||
package.path().join("codex-package.json"),
|
||||
r#"{"version":"1.2.3-alpha.4"}"#,
|
||||
)
|
||||
.expect("create runtime package manifest");
|
||||
|
||||
let context = InstallContext::from_exe(
|
||||
cfg!(target_os = "macos"),
|
||||
Some(&executable),
|
||||
/*method_override*/ None,
|
||||
);
|
||||
|
||||
assert_eq!(
|
||||
BuildInfo::resolve(&context, BUILD_COMMIT),
|
||||
BuildInfo {
|
||||
version: Version::parse("1.2.3-alpha.4").expect("valid release version"),
|
||||
build_commit: BUILD_COMMIT.to_string(),
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
/// Unpackaged builds expose their stamped commit and structured source version.
|
||||
#[test]
|
||||
fn unpackaged_runtime_uses_build_commit() {
|
||||
let context = InstallContext::from_exe(
|
||||
cfg!(target_os = "macos"),
|
||||
/*current_exe*/ None,
|
||||
/*method_override*/ None,
|
||||
);
|
||||
|
||||
assert_eq!(
|
||||
BuildInfo::resolve(&context, BUILD_COMMIT),
|
||||
BuildInfo {
|
||||
version: Version::new(0, 0, 0),
|
||||
build_commit: BUILD_COMMIT.to_string(),
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
/// Older package layouts without release metadata retain their build identity.
|
||||
#[test]
|
||||
fn legacy_package_without_version_uses_build_commit() {
|
||||
let package = tempdir().expect("create runtime package");
|
||||
let bin_dir = package.path().join("bin");
|
||||
fs::create_dir(&bin_dir).expect("create runtime binary directory");
|
||||
let executable = bin_dir.join("codex");
|
||||
fs::write(&executable, b"").expect("create runtime binary");
|
||||
fs::write(package.path().join("codex-package.json"), "{}")
|
||||
.expect("create legacy runtime package manifest");
|
||||
|
||||
let context = InstallContext::from_exe(
|
||||
cfg!(target_os = "macos"),
|
||||
Some(&executable),
|
||||
/*method_override*/ None,
|
||||
);
|
||||
|
||||
assert_eq!(
|
||||
BuildInfo::resolve(&context, BUILD_COMMIT),
|
||||
BuildInfo {
|
||||
version: Version::new(0, 0, 0),
|
||||
build_commit: BUILD_COMMIT.to_string(),
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
/// Invalid package versions cannot override the executable's stamped commit.
|
||||
#[test]
|
||||
fn invalid_package_version_uses_build_commit() {
|
||||
let package = tempdir().expect("create runtime package");
|
||||
let bin_dir = package.path().join("bin");
|
||||
fs::create_dir(&bin_dir).expect("create runtime binary directory");
|
||||
let executable = bin_dir.join("codex");
|
||||
fs::write(&executable, b"").expect("create runtime binary");
|
||||
fs::write(
|
||||
package.path().join("codex-package.json"),
|
||||
r#"{"version":"not-a-release-version"}"#,
|
||||
)
|
||||
.expect("create runtime package manifest");
|
||||
|
||||
let context = InstallContext::from_exe(
|
||||
cfg!(target_os = "macos"),
|
||||
Some(&executable),
|
||||
/*method_override*/ None,
|
||||
);
|
||||
|
||||
assert_eq!(
|
||||
BuildInfo::resolve(&context, BUILD_COMMIT),
|
||||
BuildInfo {
|
||||
version: Version::new(0, 0, 0),
|
||||
build_commit: BUILD_COMMIT.to_string(),
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
/// Serializing build information preserves both its release version and commit.
|
||||
#[test]
|
||||
fn build_info_serialization_preserves_build_provenance() {
|
||||
let build_info = BuildInfo {
|
||||
version: Version::parse("1.2.3-alpha.4").expect("valid release version"),
|
||||
build_commit: BUILD_COMMIT.to_string(),
|
||||
};
|
||||
|
||||
assert_eq!(
|
||||
serde_json::to_string(&build_info).expect("serialize build information"),
|
||||
format!("{{\"version\":\"1.2.3-alpha.4\",\"build_commit\":\"{BUILD_COMMIT}\"}}"),
|
||||
);
|
||||
assert_eq!(
|
||||
serde_json::from_str::<BuildInfo>(&format!(
|
||||
"{{\"version\":\"1.2.3-alpha.4\",\"build_commit\":\"{BUILD_COMMIT}\"}}"
|
||||
))
|
||||
.expect("deserialize build information"),
|
||||
build_info,
|
||||
);
|
||||
}
|
||||
Reference in new issue
Block a user