mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Condense TUI startup warnings (#42609)
## What changed - Coalesce configuration, skill, sandbox, and MCP startup diagnostics into a single summary below the session header, including MCP and sign-in counts. - Keep the complete warning text in the transcript and update the summary's transcript shortcut when key bindings change. - Continue rendering warnings that arrive after work begins as inline history entries. - Hide the MCP startup status row before a turn while preserving the configured interrupt shortcut. ## Testing - Add coverage for warning ordering and deduplication, transcript details, MCP sign-in counts, resumed sessions, runtime warnings, reflow, backtracking, and interruption without a visible status row. GitOrigin-RevId: 009657cf04f1d3a52270cf096eebf9db7513c040
This commit is contained in:
1 parent
ed391d4dd2
commit
32c303c197
31 files changed
+728
-69
No files matched your search
@@ -801,8 +801,18 @@ impl App {
|
||||
}
|
||||
Err(err) if self.recover_transport_error(&err) => {}
|
||||
Err(err) => {
|
||||
let warnings = self
|
||||
.transcript_cells
|
||||
.iter()
|
||||
.find_map(|cell| {
|
||||
cell.as_any()
|
||||
.downcast_ref::<history_cell::StartupWarningsCell>()
|
||||
})
|
||||
.filter(|cell| cell.pending_header)
|
||||
.map(|cell| format!("\n\nStartup warnings:\n{}", cell.messages.join("\n")))
|
||||
.unwrap_or_default();
|
||||
return Err(color_eyre::eyre::eyre!(
|
||||
"Failed to start a fresh session through the app server: {err}"
|
||||
"Failed to start a fresh session through the app server: {err}{warnings}"
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user