mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Add structured full approval reviews to extensions (#40472)
## What changed - Split the approval review contributor into a `fast_decision` path for existing evidence and a `full_review` path for structured reviews. - Add host-owned full-review inputs with action evidence, conversation history, thread and turn identifiers, approval context, and extension data. - Add structured assessment and error types, and resolve full reviews using the first contributor that claims the request. ## Testing - Cover full-review input propagation, first-claim ordering, and short-circuit behavior in the extension registry tests. GitOrigin-RevId: 6f763d874af8c0b66a0d760b7b7c7dfe32251c9e
This commit is contained in:
1 parent
bb8cada846
commit
333beecd41
11 files changed
+261
-43
No files matched your search
@@ -347,7 +347,7 @@ async fn run_guardian_review(
|
||||
&& let Some(decision) = session
|
||||
.services
|
||||
.extensions
|
||||
.approval_review(
|
||||
.fast_approval_decision(
|
||||
&session.services.session_extension_data,
|
||||
&session.services.thread_extension_data,
|
||||
&action.to_string(),
|
||||
|
||||
@@ -3095,7 +3095,7 @@ async fn escalated_retry_bypasses_extension_approval_and_runs_guardian() -> anyh
|
||||
struct AutoApprovingReviewContributor;
|
||||
|
||||
impl codex_extension_api::ApprovalReviewContributor for AutoApprovingReviewContributor {
|
||||
fn contribute<'a>(
|
||||
fn fast_decision<'a>(
|
||||
&'a self,
|
||||
_session_store: &'a codex_extension_api::ExtensionData,
|
||||
_thread_store: &'a codex_extension_api::ExtensionData,
|
||||
|
||||
Reference in new issue
Block a user