mirror of
https://github.com/openai/codex.git
synced 2026-11-13 22:47:20 +00:00
Show completion timestamps after successful TUI turns (#43558)
## What changed Replace horizontal turn separators with dim completion metadata after the final answer, including plain conversational answers. Show local completion times such as `done 2:32 PM`, adding the date for other days and the year for other years. Retain `Worked for` durations above sixty seconds and runtime metrics, and wrap metadata on narrow terminals. Restore saved completion metadata when resuming conversations or loading older history. Keep each footer after its turn's items and deduplicate it across repeated notifications and overlapping pages. Only live completions fall back to the current time when a saved timestamp is unavailable. Failed, interrupted, and in-progress turns do not receive success footers. Avoid submitting queued input or emitting completion notifications while replaying history. ## Testing Add unit and snapshot coverage for timestamp formatting, duration thresholds, muted styling, narrow layouts, live and replayed completions, missing metadata, and pagination boundaries with overlapping pages. GitOrigin-RevId: 308c35c6720720da43c9a391aa5a68c1b231c9a5
This commit is contained in:
1 parent
769a6a5bcd
commit
333c41eef6
42 files changed
+1112
-202
No files matched your search
@@ -330,9 +330,10 @@ impl ChatWidget {
|
||||
);
|
||||
}
|
||||
self.last_non_retry_error = None;
|
||||
let completion = self.completion_cell(¬ification.turn, replay_kind);
|
||||
self.on_task_complete(
|
||||
last_agent_message.map(|(_, _, text)| text),
|
||||
notification.turn.duration_ms,
|
||||
completion,
|
||||
replay_kind.is_some(),
|
||||
);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user