mirror of
https://github.com/openai/codex.git
synced 2026-11-22 07:13:50 +00:00
Include suggestion IDs in plugin install metadata (#39765)
## What changed - Add `suggestion_id` to plugin install elicitation metadata, using the same value as the elicitation request ID and plugin-install analytics event. - Leave connector install metadata unchanged by omitting the field. ## Testing - Cover plugin and connector metadata serialization. - Verify that remote plugin install metadata and analytics carry matching suggestion IDs. GitOrigin-RevId: 05dd1d210e2a82857094f09d27ecba79ee460b7e
This commit is contained in:
1 parent
097825f75a
commit
39073ca3a7
5 files changed
+31
-7
No files matched your search
@@ -41,6 +41,8 @@ pub struct RequestPluginInstallMeta<'a> {
|
||||
pub tool_id: &'a str,
|
||||
pub tool_name: &'a str,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub suggestion_id: Option<&'a str>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub install_url: Option<&'a str>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub remote_plugin_id: Option<&'a str>,
|
||||
@@ -51,6 +53,7 @@ pub struct RequestPluginInstallMeta<'a> {
|
||||
pub fn build_request_plugin_install_elicitation_request(
|
||||
suggest_reason: &str,
|
||||
tool: &DiscoverableTool,
|
||||
suggestion_id: &str,
|
||||
) -> ElicitationRequest {
|
||||
let message = suggest_reason.to_string();
|
||||
|
||||
@@ -58,6 +61,7 @@ pub fn build_request_plugin_install_elicitation_request(
|
||||
meta: Some(json!(build_request_plugin_install_meta(
|
||||
suggest_reason,
|
||||
tool,
|
||||
suggestion_id,
|
||||
))),
|
||||
message,
|
||||
requested_schema: json!({
|
||||
@@ -89,11 +93,13 @@ pub fn verified_connector_install_completed(
|
||||
fn build_request_plugin_install_meta<'a>(
|
||||
suggest_reason: &'a str,
|
||||
tool: &'a DiscoverableTool,
|
||||
suggestion_id: &'a str,
|
||||
) -> RequestPluginInstallMeta<'a> {
|
||||
let (tool_type, remote_plugin_id, app_connector_ids) = match tool {
|
||||
DiscoverableTool::Connector(_) => (DiscoverableToolType::Connector, None, None),
|
||||
let (tool_type, suggestion_id, remote_plugin_id, app_connector_ids) = match tool {
|
||||
DiscoverableTool::Connector(_) => (DiscoverableToolType::Connector, None, None, None),
|
||||
DiscoverableTool::Plugin(plugin) => (
|
||||
DiscoverableToolType::Plugin,
|
||||
Some(suggestion_id),
|
||||
plugin.remote_plugin_id.as_deref(),
|
||||
Some(plugin.app_connector_ids.as_slice()),
|
||||
),
|
||||
@@ -106,6 +112,7 @@ fn build_request_plugin_install_meta<'a>(
|
||||
suggest_reason,
|
||||
tool_id: tool.id(),
|
||||
tool_name: tool.name(),
|
||||
suggestion_id,
|
||||
install_url: tool.install_url(),
|
||||
remote_plugin_id,
|
||||
app_connector_ids,
|
||||
|
||||
Reference in new issue
Block a user