Fix main due to conflicting merge
This commit is contained in:
jif-oai authored and GitHub committed 2026-05-13 17:28:37 +02:00
1 parent 8ba6749932
commit 441c2f818f
3 files changed
-7

No files matched your search

-1
View File
@@ -1466,7 +1466,6 @@ impl Session {
contributor.on_config_changed( contributor.on_config_changed(
&self.services.session_extension_data, &self.services.session_extension_data,
&self.services.thread_extension_data, &self.services.thread_extension_data,
self.conversation_id,
previous_config, previous_config,
new_config, new_config,
); );
-5
View File
@@ -1922,7 +1922,6 @@ async fn config_change_contributor_observes_effective_config_changes() {
#[derive(Debug, PartialEq)] #[derive(Debug, PartialEq)]
struct RecordedConfigChange { struct RecordedConfigChange {
thread_id: ThreadId,
previous_model: Option<String>, previous_model: Option<String>,
new_model: Option<String>, new_model: Option<String>,
previous_disabled_tools: Vec<ToolSuggestDisabledTool>, previous_disabled_tools: Vec<ToolSuggestDisabledTool>,
@@ -1940,7 +1939,6 @@ async fn config_change_contributor_observes_effective_config_changes() {
&self, &self,
session_store: &codex_extension_api::ExtensionData, session_store: &codex_extension_api::ExtensionData,
thread_store: &codex_extension_api::ExtensionData, thread_store: &codex_extension_api::ExtensionData,
thread_id: ThreadId,
previous_config: &crate::config::Config, previous_config: &crate::config::Config,
new_config: &crate::config::Config, new_config: &crate::config::Config,
) { ) {
@@ -1948,7 +1946,6 @@ async fn config_change_contributor_observes_effective_config_changes() {
.lock() .lock()
.expect("config change records lock") .expect("config change records lock")
.push(RecordedConfigChange { .push(RecordedConfigChange {
thread_id,
previous_model: previous_config.model.clone(), previous_model: previous_config.model.clone(),
new_model: new_config.model.clone(), new_model: new_config.model.clone(),
previous_disabled_tools: previous_config.tool_suggest.disabled_tools.clone(), previous_disabled_tools: previous_config.tool_suggest.disabled_tools.clone(),
@@ -2021,7 +2018,6 @@ disabled_tools = [
]; ];
let expected = vec![ let expected = vec![
RecordedConfigChange { RecordedConfigChange {
thread_id: session.conversation_id,
previous_model: Some(original_model), previous_model: Some(original_model),
new_model: Some(next_model.to_string()), new_model: Some(next_model.to_string()),
previous_disabled_tools: original_disabled_tools.clone(), previous_disabled_tools: original_disabled_tools.clone(),
@@ -2030,7 +2026,6 @@ disabled_tools = [
saw_thread_store: true, saw_thread_store: true,
}, },
RecordedConfigChange { RecordedConfigChange {
thread_id: session.conversation_id,
previous_model: Some(next_model.to_string()), previous_model: Some(next_model.to_string()),
new_model: Some(next_model.to_string()), new_model: Some(next_model.to_string()),
previous_disabled_tools: original_disabled_tools, previous_disabled_tools: original_disabled_tools,
@@ -77,7 +77,6 @@ pub trait ConfigContributor<C>: Send + Sync {
&self, &self,
_session_store: &ExtensionData, _session_store: &ExtensionData,
_thread_store: &ExtensionData, _thread_store: &ExtensionData,
_thread_id: ThreadId,
_previous_config: &C, _previous_config: &C,
_new_config: &C, _new_config: &C,
) { ) {