mirror of
https://github.com/openai/codex.git
synced 2026-11-18 15:01:48 +00:00
Track artifact operations from trusted plugin markers (#38057)
## What changed - Recognize validated create and edit marker commands from the trusted presentations, documents, spreadsheets, and PDF plugins. - Emit a `codex_artifact_operation` analytics event plus started-count and expected-output-count metrics when a recognized marker starts through unified exec. - Attribute remote executor commands only when their plugin cache path and script contents match a trusted local plugin, including primary-runtime plugins. ## Testing - Cover supported marker combinations and reject mismatched plugins, paths, arguments, counts, and output formats. - Cover local, relocated remote, and Windows-style plugin attribution, including rejection of modified remote scripts. GitOrigin-RevId: 475cc1689aa7f371a24dec0a8bdb6f7fd5a2e922
This commit is contained in:
1 parent
285abc0368
commit
44d992c14e
18 files changed
+971
-60
No files matched your search
@@ -466,12 +466,25 @@ impl UnifiedExecProcessManager {
|
||||
&context.call_id,
|
||||
/*turn_diff_tracker*/ None,
|
||||
);
|
||||
let plugin_attribution = cwd.to_abs_path().ok().and_then(|cwd| {
|
||||
let plugin_attribution = if request.turn_environment.environment.is_remote() {
|
||||
let file_system = request.turn_environment.environment.get_filesystem();
|
||||
context
|
||||
.step_context
|
||||
.turn
|
||||
.plugin_attribution_for_command(&request.command, &cwd)
|
||||
});
|
||||
.plugin_attribution_for_executor_command(
|
||||
&request.command,
|
||||
&cwd,
|
||||
file_system.as_ref(),
|
||||
)
|
||||
.await
|
||||
} else {
|
||||
cwd.to_abs_path().ok().and_then(|cwd| {
|
||||
context
|
||||
.step_context
|
||||
.turn
|
||||
.plugin_attribution_for_command(&request.command, &cwd)
|
||||
})
|
||||
};
|
||||
let emitter = ToolEmitter::unified_exec(
|
||||
&request.command,
|
||||
cwd.clone(),
|
||||
|
||||
Reference in new issue
Block a user