mirror of
https://github.com/openai/codex.git
synced 2026-11-20 07:06:24 +00:00
Distinguish rollout IDs from thread IDs (#38127)
## Why `thread/revert` preserves a thread ID while creating a new immutable rollout. Rollout persistence and filesystem fallback therefore need to distinguish the logical thread from each physical history file. ## What changed - Add a `RolloutId` alias and canonical filename parsing for both ordinary rollouts and reverted rollouts with a distinct rollout ID. - Allow the recorder to create a replacement rollout without changing the thread ID, and add lookup by either the stable thread ID or an exact rollout ID. - Index history references and compression safety checks by rollout ID so multiple rollouts for one thread remain distinct. - Preserve the rollout path selected in SQLite when filesystem repair encounters another rollout for the same thread. ## Testing Add coverage for filename round trips, replacement rollout metadata, thread and rollout lookup, reference indexing, compression, and database path preservation. GitOrigin-RevId: 14b1d0b4a9432b341a1307afc0abadd507e7ae7d
This commit is contained in:
1 parent
2230d64464
commit
4ef836f883
18 files changed
+513
-178
No files matched your search
@@ -491,12 +491,17 @@ mod worker {
|
||||
continue;
|
||||
}
|
||||
let path = rollout_file.into_path();
|
||||
let Some(rollout_id) = crate::rollout_id_from_path(path.as_path()) else {
|
||||
stats.skipped = stats.skipped.saturating_add(1);
|
||||
metrics::file("skipped_unreadable_meta");
|
||||
continue;
|
||||
};
|
||||
let Ok(meta) = crate::read_session_meta_line(path.as_path()).await else {
|
||||
stats.skipped = stats.skipped.saturating_add(1);
|
||||
metrics::file("skipped_unreadable_meta");
|
||||
continue;
|
||||
};
|
||||
if reference_index.reference_count(meta.meta.id) > 0 {
|
||||
if reference_index.reference_count(rollout_id) > 0 {
|
||||
stats.skipped = stats.skipped.saturating_add(1);
|
||||
metrics::file("skipped_referenced");
|
||||
continue;
|
||||
|
||||
Reference in new issue
Block a user