mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Use model-specific auto-review outcome instructions (#39741)
## What changed - Add `rejection_instructions` and `timeout_instructions` to catalog-provided auto-review messages. - Use the acting model's instructions for denied and timed-out reviews across tool approvals, shell escalation, and MCP elicitation responses. - Fall back to the existing instructions only when a catalog value is absent, while preserving explicit empty-string overrides. ## Testing - Cover catalog overrides, legacy fallbacks, empty values, and separation between acting-model and reviewer-model messages. GitOrigin-RevId: c5b2c2dbdaefd45d1d658651dd1abaeb6d8c93da
This commit is contained in:
1 parent
88da5520d4
commit
4f38432d87
12 files changed
+292
-33
No files matched your search
@@ -283,7 +283,7 @@ pub(crate) async fn handle_mcp_tool_call(
|
||||
&call_id,
|
||||
invocation,
|
||||
item_metadata.clone(),
|
||||
crate::guardian::guardian_timeout_message(),
|
||||
crate::guardian::guardian_timeout_message(&turn_context.model_info),
|
||||
/*already_started*/ true,
|
||||
)
|
||||
.await
|
||||
|
||||
Reference in new issue
Block a user