mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Isolate Guardian reviewer sessions from parent extensions (#38602)
## What changed - Start Guardian reviewer delegates with an empty extension registry while preserving extension inheritance for other delegates. - Disable `GuardianV2` in the reviewer session configuration so reviews do not trigger nested Guardian processing. - Cover both the reviewer isolation and continued delivery of parent-session tool lifecycle events. GitOrigin-RevId: 858b3e23d1c06177e443fb0779fcf06cc5294fc2
This commit is contained in:
1 parent
da898490fc
commit
588ee89324
5 files changed
+121
-3
No files matched your search
@@ -1344,6 +1344,7 @@ pub(crate) fn build_guardian_review_session_config(
|
||||
for feature in [
|
||||
Feature::Collab,
|
||||
Feature::MultiAgentV2,
|
||||
Feature::GuardianV2,
|
||||
Feature::CodexHooks,
|
||||
Feature::Apps,
|
||||
Feature::Plugins,
|
||||
|
||||
@@ -3445,7 +3445,7 @@ async fn guardian_review_session_config_uses_live_network_proxy_state() {
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn guardian_review_session_config_disables_mcp_apps_plugins_and_memories() {
|
||||
async fn guardian_review_session_config_disables_mcp_apps_plugins_memories_and_guardian_v2() {
|
||||
let mut parent_config = test_config().await;
|
||||
let server: McpServerConfig =
|
||||
toml::from_str("command = \"docs-server\"").expect("deserialize MCP server");
|
||||
@@ -3461,6 +3461,10 @@ async fn guardian_review_session_config_disables_mcp_apps_plugins_and_memories()
|
||||
.features
|
||||
.enable(Feature::Plugins)
|
||||
.expect("plugins feature is configurable");
|
||||
parent_config
|
||||
.features
|
||||
.enable(Feature::GuardianV2)
|
||||
.expect("guardian v2 feature is configurable");
|
||||
parent_config.include_apps_instructions = true;
|
||||
parent_config.memories.use_memories = true;
|
||||
parent_config.memories.dedicated_tools = true;
|
||||
@@ -3477,6 +3481,7 @@ async fn guardian_review_session_config_disables_mcp_apps_plugins_and_memories()
|
||||
assert!(guardian_config.mcp_servers.get().is_empty());
|
||||
assert!(!guardian_config.features.enabled(Feature::Apps));
|
||||
assert!(!guardian_config.features.enabled(Feature::Plugins));
|
||||
assert!(!guardian_config.features.enabled(Feature::GuardianV2));
|
||||
assert!(!guardian_config.include_apps_instructions);
|
||||
assert!(!guardian_config.memories.use_memories);
|
||||
assert!(!guardian_config.memories.dedicated_tools);
|
||||
|
||||
Reference in new issue
Block a user