From 64bb8094ba3b2c77becea8281a4b070e05e6c758 Mon Sep 17 00:00:00 2001 From: Dylan Hurd Date: Tue, 4 Aug 2026 01:57:59 +0000 Subject: [PATCH] Fix typo in approval resolver name (#36822) Rename `resolve_tool_apporval` to `resolve_tool_approval` and update its call sites in the tool orchestrator. GitOrigin-RevId: bc7d9ae675b45dd5b6b5b5643fd75e532f6314ca --- codex-rs/core/src/tools/approvals.rs | 2 +- codex-rs/core/src/tools/orchestrator.rs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/codex-rs/core/src/tools/approvals.rs b/codex-rs/core/src/tools/approvals.rs index 6b4bedd00d..4d9dfd9e02 100644 --- a/codex-rs/core/src/tools/approvals.rs +++ b/codex-rs/core/src/tools/approvals.rs @@ -188,7 +188,7 @@ impl ApprovalResolution { } } -pub(super) async fn resolve_tool_apporval( +pub(super) async fn resolve_tool_approval( tool: &mut T, req: &Rq, permission_request_run_id: &str, diff --git a/codex-rs/core/src/tools/orchestrator.rs b/codex-rs/core/src/tools/orchestrator.rs index 073962db74..b994c658f6 100644 --- a/codex-rs/core/src/tools/orchestrator.rs +++ b/codex-rs/core/src/tools/orchestrator.rs @@ -7,7 +7,7 @@ retry with an escalated sandbox strategy on denial (no re‑approval thanks to caching). */ use super::approvals::ApprovalReviewer; -use super::approvals::resolve_tool_apporval; +use super::approvals::resolve_tool_approval; use crate::network_policy_decision::network_approval_context_from_payload; use crate::tools::flat_tool_name; use crate::tools::network_approval::ActiveNetworkApproval; @@ -174,7 +174,7 @@ impl ToolOrchestrator { retry_reason: None, network_approval_context: None, }; - resolve_tool_apporval( + resolve_tool_approval( tool, req, tool_ctx.call_id.as_str(), @@ -205,7 +205,7 @@ impl ToolOrchestrator { retry_reason: reason.clone(), network_approval_context: None, }; - resolve_tool_apporval( + resolve_tool_approval( tool, req, tool_ctx.call_id.as_str(), @@ -402,7 +402,7 @@ impl ToolOrchestrator { }; let permission_request_run_id = format!("{}:retry", tool_ctx.call_id); - resolve_tool_apporval( + resolve_tool_approval( tool, req, &permission_request_run_id,