mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Use ReviewDecision for MCP tool approvals (#38081)
## What changed - Add `ApprovedMcpPolicyAmendment` to represent MCP approvals that persist across sessions. - Route MCP approval responses directly through the shared `ReviewDecision` type while preserving session-only approvals, rejection reasons, timeouts, and cancellations. - Reject the MCP-only policy decision if it reaches command, shell, network, or other tool approval paths. ## Testing - Update MCP approval parsing, normalization, hook, and Guardian tests for the shared decisions. - Verify generic tool approvals reject MCP policy amendments. GitOrigin-RevId: b8cc931dc61d4c794915145273ede82b9eb30fc8
This commit is contained in:
1 parent
7c47952f7c
commit
67afc79674
17 files changed
+154
-120
No files matched your search
@@ -82,6 +82,9 @@ impl From<CoreReviewDecision> for CommandExecutionApprovalDecision {
|
||||
fn from(value: CoreReviewDecision) -> Self {
|
||||
match value {
|
||||
CoreReviewDecision::Approved => Self::Accept,
|
||||
// MCP approvals are handled through elicitations, so an MCP policy amendment should
|
||||
// never appear in a command execution approval. To be cautious here, we fail closed.
|
||||
CoreReviewDecision::ApprovedMcpPolicyAmendment => Self::Decline,
|
||||
CoreReviewDecision::ApprovedExecpolicyAmendment {
|
||||
proposed_execpolicy_amendment,
|
||||
} => Self::AcceptWithExecpolicyAmendment {
|
||||
|
||||
Reference in new issue
Block a user