mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Attribute nested REPL reviews to their tool calls (#42082)
## What changed - Retain MCP invocation metadata for Node-backed REPL servers so nested elicitations can resolve the enclosing tool call. - Use a valid, same-server `callId` from the current turn as the Guardian assessment target while continuing to review each nested action and connector independently. - Fall back to an elicitation-specific target when `callId` is missing, malformed, unknown, from another server, or from an earlier turn. ## Testing - Cover ordinary and strict reviews for `node_repl` and `cua_repl`, multiple nested decisions, unrelated servers, and invalid or stale call IDs. GitOrigin-RevId: adea4b5cff96726a540ff3b3ea902b0f5dd99299
This commit is contained in:
1 parent
2350823caa
commit
67cc3c318d
4 files changed
+366
-24
No files matched your search
@@ -1154,7 +1154,9 @@ impl Session {
|
||||
};
|
||||
turn_state.lock().await.insert_mcp_tool_approval_metadata(
|
||||
call_id.to_string(),
|
||||
(invocation.server == CODEX_APPS_MCP_SERVER_NAME).then(|| invocation.clone()),
|
||||
(invocation.server == CODEX_APPS_MCP_SERVER_NAME
|
||||
|| is_node_repl_backed_server(&invocation.server))
|
||||
.then(|| invocation.clone()),
|
||||
metadata,
|
||||
);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user