mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Generate automatic and manual conversation recaps (#40705)
## Why Users returning to a conversation need a short summary of its recent progress and next steps. ## What changed - Generate a recap for eligible idle, unfocused conversations and add it to the transcript. - Add `/recap` to request the same summary on demand, with visible progress and actionable errors. - Keep recap requests bounded and isolated, reject stale results, and retry only automatic failures. ## Testing - Cover automatic and manual generation, request eligibility, failure handling, loading-state cleanup, and temporary-thread configuration. GitOrigin-RevId: 926a88d6996d67a42809ce2c4091b13fca882b52
This commit is contained in:
1 parent
40ba7da7b4
commit
6988d390b3
17 files changed
+831
-38
No files matched your search
@@ -6,6 +6,7 @@
|
||||
use super::resize_reflow::trailing_run_start;
|
||||
use super::session_lifecycle::ThreadAttachPresentation;
|
||||
use super::*;
|
||||
use crate::app_event::RecapTrigger;
|
||||
use crate::app_event::ThreadTitleDestination;
|
||||
use crate::app_server_session::ForkGoalContinuation;
|
||||
use crate::app_server_session::UnsupportedLegacyPermissionProfile;
|
||||
@@ -2897,11 +2898,71 @@ impl App {
|
||||
AppEvent::KeymapCleared { context, action } => {
|
||||
self.apply_keymap_clear(context, action).await;
|
||||
}
|
||||
AppEvent::GenerateRecap { thread_id } => {
|
||||
if self.current_displayed_thread_id() == Some(thread_id) {
|
||||
if self.chat_widget.is_user_turn_pending_or_running() {
|
||||
self.chat_widget.add_error_message(
|
||||
"Wait for the current task to finish before running /recap.".to_string(),
|
||||
);
|
||||
} else {
|
||||
self.request_recap(app_server, thread_id, RecapTrigger::Manual);
|
||||
}
|
||||
}
|
||||
}
|
||||
AppEvent::CheckRecap { thread_id } => {
|
||||
// The inference layer stacked on this change consumes the scheduled check.
|
||||
let _ = thread_id;
|
||||
if self.current_displayed_thread_id() == Some(thread_id)
|
||||
&& !self.chat_widget.is_user_turn_pending_or_running()
|
||||
&& self.recap.should_generate(std::time::Instant::now())
|
||||
{
|
||||
self.request_recap(app_server, thread_id, RecapTrigger::Automatic);
|
||||
}
|
||||
}
|
||||
AppEvent::RecapStarted {
|
||||
thread_id,
|
||||
request_id,
|
||||
trigger,
|
||||
completed_turn_count,
|
||||
turn_revision,
|
||||
history,
|
||||
result,
|
||||
} => {
|
||||
self.handle_recap_started(
|
||||
app_server,
|
||||
recap::RecapRequest {
|
||||
thread_id,
|
||||
request_id,
|
||||
trigger,
|
||||
completed_turn_count,
|
||||
turn_revision,
|
||||
},
|
||||
history,
|
||||
result,
|
||||
);
|
||||
}
|
||||
AppEvent::RecapGenerated {
|
||||
thread_id,
|
||||
request_id,
|
||||
trigger,
|
||||
temporary_thread_id,
|
||||
completed_turn_count,
|
||||
turn_revision,
|
||||
result,
|
||||
} => {
|
||||
self.temporary_structured_requests.remove(&temporary_thread_id);
|
||||
if let Some(cell) = self.handle_generated_recap(
|
||||
recap::RecapRequest {
|
||||
thread_id,
|
||||
request_id,
|
||||
trigger,
|
||||
completed_turn_count,
|
||||
turn_revision,
|
||||
},
|
||||
temporary_thread_id,
|
||||
result,
|
||||
) {
|
||||
self.insert_history_cell(tui, Box::new(cell));
|
||||
}
|
||||
}
|
||||
AppEvent::RecapStarted { .. } | AppEvent::RecapGenerated { .. } => {}
|
||||
}
|
||||
Ok(AppRunControl::Continue)
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user