mirror of
https://github.com/openai/codex.git
synced 2026-11-09 00:39:32 +00:00
Use captured action settings for Guardian reviews (#44574)
## Why Model changes during a turn and catalog refreshes can leave Guardian reviews using settings or metadata that do not match the action being reviewed. ## What changed - Use the action's captured model, reasoning effort, reasoning summary, and personality when configuring reviews. - Preserve captured model metadata when falling back to the parent model, while resolving a separate reviewer against the current catalog on each attempt. - Evaluate live managed review requirements against the action's model and use its metadata for computer-use review behavior. - Include personality in the review session reuse key so personality changes invalidate cached sessions. ## Testing Add regression coverage for delayed and new actions across model changes and catalog refreshes, required-review routing, and session reuse when policy or personality changes. Extend integration tests to cover reviewer reuse across parent model changes and verify that interrupted reviews cannot execute commands after a delayed approval arrives. GitOrigin-RevId: 5b434568e113e44bf7177780f2ae13192b55e942
This commit is contained in:
1 parent
6baa076eb6
commit
6bb5be869f
10 files changed
+667
-161
No files matched your search
@@ -113,7 +113,7 @@ impl ResolvedStepSettings {
|
||||
&self.selected.collaboration_mode
|
||||
}
|
||||
|
||||
pub(super) fn personality(&self) -> Option<Personality> {
|
||||
pub(crate) fn personality(&self) -> Option<Personality> {
|
||||
self.selected.personality
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user