mirror of
https://github.com/openai/codex.git
synced 2026-11-19 23:05:23 +00:00
Add TUI notification condition config (#17175)
Problem: TUI desktop notifications are hard-gated on terminal focus, so terminal/IDE hosts that want in-focus notifications cannot opt in. Solution: Add a flat `[tui] notification_condition` setting (`unfocused` by default, `always` opt-in), carry grouped TUI notification settings through runtime config, apply method + condition together in the TUI, and regenerate the config schema.
This commit is contained in:
1 parent
2f9090be62
commit
6dc5391c7c
8 files changed
+191
-48
No files matched your search
@@ -3604,7 +3604,10 @@ impl App {
|
||||
let app_event_tx = AppEventSender::new(app_event_tx);
|
||||
emit_project_config_warnings(&app_event_tx, &config);
|
||||
emit_system_bwrap_warning(&app_event_tx, &config);
|
||||
tui.set_notification_method(config.tui_notification_method);
|
||||
tui.set_notification_settings(
|
||||
config.tui_notifications.method,
|
||||
config.tui_notifications.condition,
|
||||
);
|
||||
|
||||
let harness_overrides =
|
||||
normalize_harness_overrides_for_cwd(harness_overrides, &config.cwd)?;
|
||||
@@ -4145,7 +4148,10 @@ impl App {
|
||||
Ok(resumed) => {
|
||||
self.shutdown_current_thread(app_server).await;
|
||||
self.config = resume_config;
|
||||
tui.set_notification_method(self.config.tui_notification_method);
|
||||
tui.set_notification_settings(
|
||||
self.config.tui_notifications.method,
|
||||
self.config.tui_notifications.condition,
|
||||
);
|
||||
self.file_search
|
||||
.update_search_dir(self.config.cwd.to_path_buf());
|
||||
match self
|
||||
|
||||
Reference in new issue
Block a user