mirror of
https://github.com/openai/codex.git
synced 2026-11-13 06:45:07 +00:00
Remove WebSocket transport from code-mode hosts (#40692)
## What changed - Accept only `http://` and `https://` gRPC endpoints for app server `--code-mode-host` connections. - Limit the standalone code-mode host to stdio and gRPC listeners. - Remove the WebSocket session provider, dual-WebSocket negotiation, transport lanes, and related dependencies and tests. - Keep coverage for shared and prewarmed gRPC hosts and reject WebSocket host URLs in CLI parsing tests. GitOrigin-RevId: 8792604e79ffd54ce776074a4dc3f7d55e63752a
This commit is contained in:
1 parent
9be8d6e1c3
commit
725b3a44f8
31 files changed
+153
-2766
No files matched your search
@@ -4487,35 +4487,6 @@ mod tests {
|
||||
assert!(err.to_string().contains("is empty"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn app_server_code_mode_host_url_parses_independently_of_listen_transport() {
|
||||
let app_server = app_server_from_args(
|
||||
[
|
||||
"codex",
|
||||
"app-server",
|
||||
"--code-mode-host",
|
||||
"wss://example.test/code-mode",
|
||||
"--listen",
|
||||
"ws://127.0.0.1:4500",
|
||||
]
|
||||
.as_ref(),
|
||||
);
|
||||
|
||||
assert_eq!(
|
||||
app_server.code_mode_host.code_mode_host,
|
||||
Some(
|
||||
url::Url::parse("wss://example.test/code-mode")
|
||||
.expect("test endpoint should parse")
|
||||
)
|
||||
);
|
||||
assert_eq!(
|
||||
app_server.listen,
|
||||
codex_app_server::AppServerTransport::WebSocket {
|
||||
bind_address: "127.0.0.1:4500".parse().expect("valid socket address"),
|
||||
}
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn app_server_grpc_code_mode_host_url_parses_independently_of_listen_transport() {
|
||||
let app_server = app_server_from_args(
|
||||
@@ -4541,7 +4512,13 @@ mod tests {
|
||||
for endpoint in [
|
||||
"ftp://127.0.0.1:8765",
|
||||
"ws://",
|
||||
"ws://127.0.0.1:8765",
|
||||
"wss://example.test/code-mode",
|
||||
"ws://alice:secret@example.test/code-mode",
|
||||
"wss://alice:secret@example.test/code-mode",
|
||||
"wss://example.test/code-mode#fragment",
|
||||
"http://",
|
||||
"https://example.test/#fragment",
|
||||
"https://example.test/code-mode",
|
||||
"http://alice:secret@example.test",
|
||||
"https://alice:secret@example.test",
|
||||
|
||||
Reference in new issue
Block a user