mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Set turn triggers for guardian and memory requests (#44298)
## What changed Populate `turn_trigger` in request metadata with `guardian_review` for guardian reviews, `guardian_classifier` for classifier requests, and `memory_consolidation` for both detached memory requests and consolidation agent turns. ## Testing Extend request metadata assertions to cover each trigger across guardian reviews, classifier requests, and both memory startup phases. GitOrigin-RevId: 2dc3c173ede6563b942b8099ad9901c32967b969
This commit is contained in:
1 parent
87cf20ee49
commit
742472c525
9 files changed
+29
-1
No files matched your search
@@ -692,6 +692,7 @@ async fn run_review_on_session(
|
||||
.map(|id| HashMap::from([("parent_response_id".to_owned(), id.clone())])),
|
||||
)
|
||||
.on_start(TurnStartOptions {
|
||||
turn_trigger: Some("guardian_review".to_owned()),
|
||||
final_output_json_schema: Some(params.schema.clone()),
|
||||
service_tier: None,
|
||||
parent_turn_id: Some(parent_turn.sub_id.clone()),
|
||||
|
||||
@@ -2192,6 +2192,12 @@ async fn guardian_review_request_layout_matches_model_visible_request_snapshot()
|
||||
Some(codex_analytics::GuardianReviewSessionKind::TrunkNew)
|
||||
));
|
||||
let request = request_log.single_request();
|
||||
let turn_metadata: serde_json::Value = serde_json::from_str(
|
||||
&request
|
||||
.header("x-codex-turn-metadata")
|
||||
.expect("guardian turn metadata"),
|
||||
)?;
|
||||
assert_eq!(turn_metadata["turn_trigger"], "guardian_review");
|
||||
let request_body = request.body_json();
|
||||
assert!(
|
||||
request_body.get("tools").is_none(),
|
||||
|
||||
Reference in new issue
Block a user