From 77da2843a9e5a5720dad26bb909053b242f08618 Mon Sep 17 00:00:00 2001 From: aibrahim-oai Date: Fri, 11 Jul 2025 13:23:00 -0700 Subject: [PATCH] Fix retry tests by setting env once --- codex-rs/core/src/chat_completions.rs | 7 +++++++ codex-rs/core/src/client.rs | 12 ------------ 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/codex-rs/core/src/chat_completions.rs b/codex-rs/core/src/chat_completions.rs index 331a0892f3..1a5f9e75ea 100644 --- a/codex-rs/core/src/chat_completions.rs +++ b/codex-rs/core/src/chat_completions.rs @@ -517,6 +517,13 @@ mod tests { .create_async() .await; + // Ensure we control the retry behaviour for the remainder of this test + // suite. This test is executed first alphabetically so it sets the + // value before any use of the flag. + unsafe { + std::env::set_var("OPENAI_REQUEST_MAX_RETRIES", "1"); + } + let config = sample_config(&server, WireApi::Chat); let provider = config.model_provider.clone(); diff --git a/codex-rs/core/src/client.rs b/codex-rs/core/src/client.rs index e28810e953..e7be198c49 100644 --- a/codex-rs/core/src/client.rs +++ b/codex-rs/core/src/client.rs @@ -455,10 +455,6 @@ data: {{\"type\":\"response.completed\",\"response\":{{\"id\":\"{id}\",\"output\ .create_async() .await; - unsafe { - std::env::set_var("OPENAI_REQUEST_MAX_RETRIES", "1"); - } - let config = sample_config(&server); let provider = config.model_provider.clone(); let client = ModelClient::new( @@ -503,10 +499,6 @@ data: {{\"type\":\"response.completed\",\"response\":{{\"id\":\"{id}\",\"output\ .create_async() .await; - unsafe { - std::env::set_var("OPENAI_REQUEST_MAX_RETRIES", "1"); - } - let config = sample_config(&server); let provider = config.model_provider.clone(); let client = ModelClient::new( @@ -532,10 +524,6 @@ data: {{\"type\":\"response.completed\",\"response\":{{\"id\":\"{id}\",\"output\ .create_async() .await; - unsafe { - std::env::set_var("OPENAI_REQUEST_MAX_RETRIES", "0"); - } - let config = sample_config(&server); let provider = config.model_provider.clone(); let client = ModelClient::new(