mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Stop TUI chats on misalignment policy violations (#39261)
## Why When the app server reports a misalignment policy violation, the TUI must stop the affected chat rather than allow more work to continue in it. ## What changed - Finalize the active turn, clear queued and draft input, disable the composer, and reject further operations and interactive requests for the stopped chat. - Interrupt an active side conversation when its parent reports the violation, and prevent queued turns, forks, approvals, or goal resumption from restarting work. - Show a non-dismissible precaution view that directs users to start a new chat or resume another one, with agent command center navigation for remote sessions. ## Testing Added coverage for stopped-chat behavior, parent/side-thread handling, blocked goal resumption, navigation actions, and narrow and remote-session rendering. GitOrigin-RevId: 0268c46a19294a17765ea4099f389f15ffaaf030
This commit is contained in:
1 parent
3006151ad4
commit
785ecd7452
16 files changed
+452
-3
No files matched your search
@@ -0,0 +1,121 @@
|
||||
use super::*;
|
||||
use pretty_assertions::assert_eq;
|
||||
|
||||
const ERROR_MESSAGE: &str = "Responses API returned misalignment_policy_violation";
|
||||
|
||||
#[tokio::test]
|
||||
async fn misalignment_policy_failure_stops_the_thread_and_renders_once() {
|
||||
let (mut chat, mut rx, mut op_rx) = make_chatwidget_manual(/*model_override*/ None).await;
|
||||
let thread_id = ThreadId::new();
|
||||
chat.thread_id = Some(thread_id);
|
||||
handle_turn_started(&mut chat, "turn-1");
|
||||
chat.handle_server_notification(
|
||||
ServerNotification::ModelSafetyBufferingUpdated(ModelSafetyBufferingUpdatedNotification {
|
||||
thread_id: thread_id.to_string(),
|
||||
turn_id: "turn-1".to_string(),
|
||||
model: "current-model".to_string(),
|
||||
use_cases: Vec::new(),
|
||||
reasons: Vec::new(),
|
||||
show_buffering_ui: true,
|
||||
faster_model: None,
|
||||
}),
|
||||
/*replay_kind*/ None,
|
||||
);
|
||||
assert!(render_bottom_popup(&chat, /*width*/ 80).contains("thinking a bit more"));
|
||||
chat.queue_user_message(UserMessage::from("queued follow-up"));
|
||||
chat.bottom_pane
|
||||
.set_composer_text("stale draft".to_string(), Vec::new(), Vec::new());
|
||||
drain_insert_history(&mut rx);
|
||||
|
||||
handle_error(
|
||||
&mut chat,
|
||||
ERROR_MESSAGE,
|
||||
Some(CodexErrorInfo::MisalignmentPolicyViolation),
|
||||
);
|
||||
|
||||
assert!(!chat.bottom_pane.is_task_running());
|
||||
assert!(!chat.bottom_pane.composer_input_enabled());
|
||||
assert!(chat.queued_user_message_texts().is_empty());
|
||||
assert_eq!(chat.bottom_pane.composer_text_with_pending(), "");
|
||||
|
||||
let popup = render_bottom_popup(&chat, /*width*/ 80);
|
||||
assert_chatwidget_snapshot!("misalignment_policy_violation", popup);
|
||||
assert_chatwidget_snapshot!(
|
||||
"misalignment_policy_violation_narrow",
|
||||
render_bottom_popup(&chat, /*width*/ 38)
|
||||
);
|
||||
|
||||
chat.submit_user_message(UserMessage::from("direct follow-up"));
|
||||
chat.queue_user_message(UserMessage::from("queued follow-up"));
|
||||
assert!(!chat.submit_op(Op::Compact));
|
||||
assert!(!chat.submit_op(Op::run_user_shell_command("echo unsafe".to_string())));
|
||||
assert!(!chat.maybe_send_next_queued_input());
|
||||
assert!(chat.queued_user_message_texts().is_empty());
|
||||
assert_no_submit_op(&mut op_rx);
|
||||
|
||||
chat.handle_server_request(
|
||||
ServerRequest::ToolRequestUserInput {
|
||||
request_id: AppServerRequestId::Integer(1),
|
||||
params: ToolRequestUserInputParams {
|
||||
thread_id: thread_id.to_string(),
|
||||
turn_id: "turn-1".to_string(),
|
||||
item_id: "input-1".to_string(),
|
||||
questions: Vec::new(),
|
||||
is_blocking: true,
|
||||
auto_resolution_ms: None,
|
||||
},
|
||||
},
|
||||
/*replay_kind*/ None,
|
||||
);
|
||||
|
||||
chat.handle_server_notification(
|
||||
ServerNotification::TurnCompleted(TurnCompletedNotification {
|
||||
thread_id: thread_id.to_string(),
|
||||
turn: app_server_turn(
|
||||
"turn-1",
|
||||
AppServerTurnStatus::Failed,
|
||||
/*duration_ms*/ None,
|
||||
Some(AppServerTurnError {
|
||||
message: ERROR_MESSAGE.to_string(),
|
||||
codex_error_info: Some(CodexErrorInfo::MisalignmentPolicyViolation),
|
||||
additional_details: None,
|
||||
}),
|
||||
),
|
||||
}),
|
||||
/*replay_kind*/ None,
|
||||
);
|
||||
|
||||
assert_eq!(render_bottom_popup(&chat, /*width*/ 80), popup);
|
||||
assert!(drain_insert_history(&mut rx).is_empty());
|
||||
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Esc));
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
|
||||
assert_matches!(rx.try_recv(), Ok(AppEvent::NewSession { name: None }));
|
||||
assert!(rx.try_recv().is_err());
|
||||
|
||||
chat.show_misalignment_policy_precaution();
|
||||
assert_eq!(render_bottom_popup(&chat, /*width*/ 80), popup);
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
|
||||
assert_matches!(rx.try_recv(), Ok(AppEvent::NewSession { name: None }));
|
||||
|
||||
chat.show_misalignment_policy_precaution();
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Down));
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
|
||||
assert_matches!(rx.try_recv(), Ok(AppEvent::OpenResumePicker));
|
||||
assert!(chat.bottom_pane.has_active_view());
|
||||
|
||||
chat.remote_connection = Some(crate::status::remote_connection::RemoteConnectionStatus {
|
||||
address: "wss://remote.example.com".to_string(),
|
||||
version: "v1.0.0".to_string(),
|
||||
});
|
||||
chat.show_misalignment_policy_precaution();
|
||||
assert_chatwidget_snapshot!(
|
||||
"misalignment_policy_violation_remote",
|
||||
render_bottom_popup(&chat, /*width*/ 80)
|
||||
);
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Down));
|
||||
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
|
||||
assert_matches!(rx.try_recv(), Ok(AppEvent::OpenAgentsOverview));
|
||||
assert!(chat.bottom_pane.has_active_view());
|
||||
}
|
||||
Reference in new issue
Block a user