Remove first-party type from app metadata (#34844)

## What changed

Remove `first_party_type` from connector app metadata and the app-server v2
protocol. Update metadata conversion and merge paths, generated JSON and
TypeScript schemas, and affected test fixtures to match.

GitOrigin-RevId: 3f2e56eca68352360d8c0d99d48486ae65d664c1

codex-rs/app-server-protocol/schema/json/ServerNotification.json

@@ -353,12 +353,6 @@
             "null"
           ]
         },
-        "firstPartyType": {
-          "type": [
-            "string",
-            "null"
-          ]
-        },
         "review": {
           "anyOf": [
             {

codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json

@@ -6619,12 +6619,6 @@
               "null"
             ]
           },
-          "firstPartyType": {
-            "type": [
-              "string",
-              "null"
-            ]
-          },
           "review": {
             "anyOf": [
               {

codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json

@@ -635,12 +635,6 @@
             "null"
           ]
         },
-        "firstPartyType": {
-          "type": [
-            "string",
-            "null"
-          ]
-        },
         "review": {
           "anyOf": [
             {

codex-rs/app-server-protocol/schema/json/v2/AppListUpdatedNotification.json

@@ -175,12 +175,6 @@
             "null"
           ]
         },
-        "firstPartyType": {
-          "type": [
-            "string",
-            "null"
-          ]
-        },
         "review": {
           "anyOf": [
             {

codex-rs/app-server-protocol/schema/json/v2/AppsListResponse.json

@@ -175,12 +175,6 @@
             "null"
           ]
         },
-        "firstPartyType": {
-          "type": [
-            "string",
-            "null"
-          ]
-        },
         "review": {
           "anyOf": [
             {

codex-rs/app-server-protocol/schema/typescript/v2/AppMetadata.ts

@@ -4,4 +4,4 @@
 import type { AppReview } from "./AppReview";
 import type { AppScreenshot } from "./AppScreenshot";
 
-export type AppMetadata = { review: AppReview | null, categories: Array<string> | null, subCategories: Array<string> | null, seoDescription: string | null, screenshots: Array<AppScreenshot> | null, developer: string | null, version: string | null, versionId: string | null, versionNotes: string | null, firstPartyType: string | null, firstPartyRequiresInstall: boolean | null, showInComposerWhenUnlinked: boolean | null, };
+export type AppMetadata = { review: AppReview | null, categories: Array<string> | null, subCategories: Array<string> | null, seoDescription: string | null, screenshots: Array<AppScreenshot> | null, developer: string | null, version: string | null, versionId: string | null, versionNotes: string | null, firstPartyRequiresInstall: boolean | null, showInComposerWhenUnlinked: boolean | null, };

codex-rs/app-server-protocol/src/protocol/v2/apps.rs

@@ -107,7 +107,6 @@ pub struct AppMetadata {
     pub version: Option<String>,
     pub version_id: Option<String>,
     pub version_notes: Option<String>,
-    pub first_party_type: Option<String>,
     pub first_party_requires_install: Option<bool>,
     pub show_in_composer_when_unlinked: Option<bool>,
 }

codex-rs/app-server/src/app_info.rs

@@ -149,7 +149,6 @@ fn app_metadata_to_api(metadata: AppMetadata) -> ApiAppMetadata {
         version,
         version_id,
         version_notes,
-        first_party_type,
         first_party_requires_install,
         show_in_composer_when_unlinked,
     } = metadata;
@@ -164,7 +163,6 @@ fn app_metadata_to_api(metadata: AppMetadata) -> ApiAppMetadata {
         version,
         version_id,
         version_notes,
-        first_party_type,
         first_party_requires_install,
         show_in_composer_when_unlinked,
     }

codex-rs/app-server/tests/suite/v2/app_list.rs

@@ -596,7 +596,6 @@ async fn list_apps_emits_updates_and_returns_after_both_lists_load() -> Result<(
         version: Some("1.2.3".to_string()),
         version_id: Some("version_123".to_string()),
         version_notes: Some("Fixes and improvements".to_string()),
-        first_party_type: Some("internal".to_string()),
         first_party_requires_install: Some(true),
         show_in_composer_when_unlinked: Some(true),
     });

codex-rs/app-server/tests/suite/v2/app_read.rs

@@ -497,7 +497,6 @@ fn app_response(id: &str, name: &str, icon_url: Option<&str>) -> Value {
             "version": "1.0.0",
             "version_id": "version-1",
             "version_notes": "Initial release",
-            "first_party_type": "must-not-escape",
             "first_party_requires_install": true,
             "show_in_composer_when_unlinked": true,
             "subtitle": "must-not-escape",

codex-rs/app-server/tests/suite/v2/plugin_read.rs

@@ -1678,7 +1678,6 @@ async fn plugin_read_returns_app_metadata_category() -> Result<()> {
                 version: None,
                 version_id: None,
                 version_notes: None,
-                first_party_type: None,
                 first_party_requires_install: None,
                 show_in_composer_when_unlinked: None,
             }),
@@ -1784,7 +1783,6 @@ async fn plugin_read_hides_apps_for_api_key_auth() -> Result<()> {
             version: None,
             version_id: None,
             version_notes: None,
-            first_party_type: None,
             first_party_requires_install: None,
             show_in_composer_when_unlinked: None,
         }),

codex-rs/connectors/src/app_info.rs

@@ -51,7 +51,6 @@ pub struct AppMetadata {
     pub version: Option<String>,
     pub version_id: Option<String>,
     pub version_notes: Option<String>,
-    pub first_party_type: Option<String>,
     pub first_party_requires_install: Option<bool>,
     pub show_in_composer_when_unlinked: Option<bool>,
 }

codex-rs/connectors/src/lib.rs

@@ -429,11 +429,6 @@ fn merge_directory_app(existing: &mut DirectoryApp, incoming: DirectoryApp) {
             {
                 existing_app_metadata.version_notes = incoming_app_metadata.version_notes;
             }
-            if existing_app_metadata.first_party_type.is_none()
-                && incoming_app_metadata.first_party_type.is_some()
-            {
-                existing_app_metadata.first_party_type = incoming_app_metadata.first_party_type;
-            }
             if existing_app_metadata.first_party_requires_install.is_none()
                 && incoming_app_metadata.first_party_requires_install.is_some()
             {

codex-rs/tui/src/app_info.rs

@@ -100,7 +100,6 @@ fn app_metadata_from_api(metadata: ApiAppMetadata) -> AppMetadata {
         version,
         version_id,
         version_notes,
-        first_party_type,
         first_party_requires_install,
         show_in_composer_when_unlinked,
     } = metadata;
@@ -119,7 +118,6 @@ fn app_metadata_from_api(metadata: ApiAppMetadata) -> AppMetadata {
         version,
         version_id,
         version_notes,
-        first_party_type,
         first_party_requires_install,
         show_in_composer_when_unlinked,
     }