github/codex
4
0 Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-10 08:43:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject implicitly discovered bare Git repositories (#36924)

Browse Source 
## Why

A repository can contain a tracked directory that Git implicitly treats as a bare
repository. Its configuration may select helpers such as `core.fsmonitor`, causing
Codex Git operations in that directory to execute repository-controlled code.

## What changed

- Pass `-c safe.bareRepository=explicit` to Codex-managed Git commands so they
  reject implicitly discovered bare repositories.
- Continue to support repositories explicitly selected with `--git-dir` or
  `GIT_DIR`.

## Testing

Add a regression test that clones a repository containing a tracked embedded Git
repository and verifies that guarded Git inspection rejects it without running
its configured filesystem monitor.

GitOrigin-RevId: 344b5bc1e0ffa94f2a1b788488aa653222da10f3
This commit is contained in:
Jeremy Rose authored and copyberry committed 2026-08-04 16:53:33 +00:00
1 parent 02bc1dd796
commit 7ada37a15e
13 files changed
+226 -15
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

codex-rs/git-utils/src/operations.rs
+3 -1
View File
@@ -100,7 +100,9 @@ where
{
let iterator = args.into_iter();
let (lower, upper) = iterator.size_hint();
let mut args_vec = Vec::with_capacity(upper.unwrap_or(lower) + 2);
let mut args_vec = Vec::with_capacity(upper.unwrap_or(lower) + 4);
args_vec.push(OsString::from("-c"));
args_vec.push(OsString::from(crate::SAFE_BARE_REPOSITORY_CONFIG));
// Keep internal Git helper commands independent of configured hook directories.
args_vec.push(OsString::from("-c"));
args_vec.push(OsString::from(format!(