mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Include the final agent message in turn completion summaries (#34777)
## Why Streamed message deltas can be dropped when the transport is saturated, leaving clients with a truncated final response. ## What changed - Include the last non-empty final agent message in successful `turn/completed` notifications and mark the items as a summary. - Treat completed message content as authoritative in the TUI, repairing an incomplete stream while avoiding duplicate messages when `item/completed` was already received. - Continue backfilling full turn items for persisted `codex exec` threads when a completion contains only the summary view. ## Testing Added coverage for completion summaries, dropped stream deltas, duplicate item handling, and directive-only responses. GitOrigin-RevId: ffe9d36d683d6b6690e4a468ff68aa9189fe6ab7
This commit is contained in:
1 parent
730ec92003
commit
80f3c3141e
15 files changed
+275
-56
No files matched your search
@@ -107,20 +107,9 @@ impl ChatWidget {
|
||||
from_replay: bool,
|
||||
) {
|
||||
self.input_queue.submit_pending_steers_after_interrupt = false;
|
||||
// Use `last_agent_message` from the turn-complete notification as the copy
|
||||
// source only when no earlier item-level event (AgentMessageItem, plan
|
||||
// commit, review output) already recorded markdown for this turn. This
|
||||
// prevents the final summary from overwriting a more specific source.
|
||||
let sanitized_last_agent_message = last_agent_message.as_deref().map(|message| {
|
||||
parse_assistant_markdown(message, self.config.cwd.as_path()).visible_markdown
|
||||
});
|
||||
if let Some(message) = sanitized_last_agent_message
|
||||
.as_ref()
|
||||
.filter(|message| !message.is_empty())
|
||||
&& !self.transcript.saw_copy_source_this_turn
|
||||
{
|
||||
self.record_agent_markdown(message);
|
||||
}
|
||||
// For desktop notifications: prefer the notification payload, fall back to
|
||||
// the item-level copy source if present, otherwise send an empty string.
|
||||
let notification_response = sanitized_last_agent_message
|
||||
|
||||
Reference in new issue
Block a user