mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
Remove js_repl feature (#19410)
This commit is contained in:
1 parent
cf02e9c052
commit
8a559e7938
63 files changed
+77
-9261
No files matched your search
@@ -59,23 +59,6 @@ fn image_detail_original_is_removed_and_disabled_by_default() {
|
||||
assert_eq!(Feature::ImageDetailOriginal.default_enabled(), false);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn js_repl_is_experimental_and_user_toggleable() {
|
||||
let spec = Feature::JsRepl.info();
|
||||
let stage = spec.stage;
|
||||
let expected_node_version = include_str!("../../node-version.txt").trim_end();
|
||||
|
||||
assert!(matches!(stage, Stage::Experimental { .. }));
|
||||
assert_eq!(stage.experimental_menu_name(), Some("JavaScript REPL"));
|
||||
assert_eq!(
|
||||
stage.experimental_menu_description().map(str::to_owned),
|
||||
Some(format!(
|
||||
"Enable a persistent Node-backed JavaScript REPL for interactive website debugging and other inline JavaScript execution capabilities. Requires Node >= v{expected_node_version} installed."
|
||||
))
|
||||
);
|
||||
assert_eq!(Feature::JsRepl.default_enabled(), false);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn code_mode_only_requires_code_mode() {
|
||||
let mut features = Features::with_defaults();
|
||||
@@ -222,6 +205,20 @@ fn image_detail_original_is_a_removed_feature_key() {
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn js_repl_features_are_removed_feature_keys() {
|
||||
assert_eq!(Feature::JsRepl.stage(), Stage::Removed);
|
||||
assert_eq!(Feature::JsRepl.default_enabled(), false);
|
||||
assert_eq!(feature_for_key("js_repl"), Some(Feature::JsRepl));
|
||||
|
||||
assert_eq!(Feature::JsReplToolsOnly.stage(), Stage::Removed);
|
||||
assert_eq!(Feature::JsReplToolsOnly.default_enabled(), false);
|
||||
assert_eq!(
|
||||
feature_for_key("js_repl_tools_only"),
|
||||
Some(Feature::JsReplToolsOnly)
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn tool_call_mcp_elicitation_is_stable_and_enabled_by_default() {
|
||||
assert_eq!(Feature::ToolCallMcpElicitation.stage(), Stage::Stable);
|
||||
@@ -353,6 +350,25 @@ fn from_sources_ignores_removed_image_detail_original_feature_key() {
|
||||
assert_eq!(features, Features::with_defaults());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn from_sources_ignores_removed_js_repl_feature_keys() {
|
||||
let features_toml = FeaturesToml::from(BTreeMap::from([
|
||||
("js_repl".to_string(), true),
|
||||
("js_repl_tools_only".to_string(), true),
|
||||
]));
|
||||
|
||||
let features = Features::from_sources(
|
||||
FeatureConfigSource {
|
||||
features: Some(&features_toml),
|
||||
..Default::default()
|
||||
},
|
||||
FeatureConfigSource::default(),
|
||||
FeatureOverrides::default(),
|
||||
);
|
||||
|
||||
assert_eq!(features, Features::with_defaults());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn multi_agent_v2_feature_config_deserializes_boolean_toggle() {
|
||||
let features: FeaturesToml = toml::from_str(
|
||||
|
||||
Reference in new issue
Block a user