Report MCP tool discovery errors in server status (#42598)

## Why

An empty tool map does not distinguish a successfully returned empty catalog from a server whose startup or tool discovery failed.

## What changed

- Add nullable `toolsError` to each `mcpServerStatus/list` entry when no catalog is available because startup or tool discovery failed.
- Keep `toolsError` null for returned catalogs, including cached and empty catalogs, and continue returning healthy servers when another server fails.
- Update the protocol schemas and generated TypeScript type.

## Testing

- Extend the app-server status integration test with a broken MCP server and verify its error without losing the healthy server's inventory.

GitOrigin-RevId: 30b4ca4d9a45cec6998f5f626d3fddbee90a525d
This commit is contained in:
victor-openai authored and copyberry committed 2026-09-03 18:36:58 +00:00
1 parent f60dfe80b5
commit 8f31b64c7f
19 files changed
+108 -30

No files matched your search

@@ -14581,6 +14581,13 @@
"$ref": "#/definitions/v2/Tool" "$ref": "#/definitions/v2/Tool"
}, },
"type": "object" "type": "object"
},
"toolsError": {
"description": "Tool discovery failed and no catalog was returned. Null when a catalog is returned, including cached or empty catalogs.",
"type": [
"string",
"null"
]
} }
}, },
"required": [ "required": [
@@ -10653,6 +10653,13 @@
"$ref": "#/definitions/Tool" "$ref": "#/definitions/Tool"
}, },
"type": "object" "type": "object"
},
"toolsError": {
"description": "Tool discovery failed and no catalog was returned. Null when a catalog is returned, including cached or empty catalogs.",
"type": [
"string",
"null"
]
} }
}, },
"required": [ "required": [
@@ -116,6 +116,13 @@
"$ref": "#/definitions/Tool" "$ref": "#/definitions/Tool"
}, },
"type": "object" "type": "object"
},
"toolsError": {
"description": "Tool discovery failed and no catalog was returned. Null when a catalog is returned, including cached or empty catalogs.",
"type": [
"string",
"null"
]
} }
}, },
"required": [ "required": [
@@ -12,4 +12,9 @@ export type McpServerStatus = { name: string,
/** /**
* Current thread-runtime connection state; null when unavailable or the configuration changed. * Current thread-runtime connection state; null when unavailable or the configuration changed.
*/ */
runtimeStatus: McpServerConnectionStatus | null, pluginId: string | null, serverInfo: McpServerInfo | null, tools: { [key in string]?: Tool }, resources: Array<Resource>, resourceTemplates: Array<ResourceTemplate>, authStatus: McpAuthStatus, }; runtimeStatus: McpServerConnectionStatus | null, pluginId: string | null, serverInfo: McpServerInfo | null, tools: { [key in string]?: Tool },
/**
* Tool discovery failed and no catalog was returned.
* Null when a catalog is returned, including cached or empty catalogs.
*/
toolsError: string | null, resources: Array<Resource>, resourceTemplates: Array<ResourceTemplate>, authStatus: McpAuthStatus, };
@@ -79,6 +79,9 @@ pub struct McpServerStatus {
pub plugin_id: Option<String>, pub plugin_id: Option<String>,
pub server_info: Option<McpServerInfo>, pub server_info: Option<McpServerInfo>,
pub tools: std::collections::HashMap<String, McpTool>, pub tools: std::collections::HashMap<String, McpTool>,
/// Tool discovery failed and no catalog was returned.
/// Null when a catalog is returned, including cached or empty catalogs.
pub tools_error: Option<String>,
pub resources: Vec<McpResource>, pub resources: Vec<McpResource>,
pub resource_templates: Vec<McpResourceTemplate>, pub resource_templates: Vec<McpResourceTemplate>,
pub auth_status: McpAuthStatus, pub auth_status: McpAuthStatus,
@@ -2578,6 +2578,7 @@ fn mcp_server_elicitation_response_serializes_nullable_content() {
fn mcp_server_status_serializes_absent_server_info_as_null() { fn mcp_server_status_serializes_absent_server_info_as_null() {
let response = ListMcpServerStatusResponse { let response = ListMcpServerStatusResponse {
data: vec![McpServerStatus { data: vec![McpServerStatus {
tools_error: None,
name: "not-ready".to_string(), name: "not-ready".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
@@ -2599,6 +2600,7 @@ fn mcp_server_status_serializes_absent_server_info_as_null() {
"pluginId": null, "pluginId": null,
"serverInfo": null, "serverInfo": null,
"tools": {}, "tools": {},
"toolsError": null,
"resources": [], "resources": [],
"resourceTemplates": [], "resourceTemplates": [],
"authStatus": "unknown", "authStatus": "unknown",
@@ -2623,6 +2625,7 @@ fn mcp_server_status_accepts_older_inventory_without_runtime_status() {
assert_eq!( assert_eq!(
status, status,
McpServerStatus { McpServerStatus {
tools_error: None,
name: "older-server".to_string(), name: "older-server".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
@@ -2694,6 +2697,7 @@ fn mcp_server_status_updated_serializes_failure_reason() {
fn mcp_server_status_serializes_absent_server_info_metadata_as_null() { fn mcp_server_status_serializes_absent_server_info_metadata_as_null() {
let response = ListMcpServerStatusResponse { let response = ListMcpServerStatusResponse {
data: vec![McpServerStatus { data: vec![McpServerStatus {
tools_error: None,
name: "initialized".to_string(), name: "initialized".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: Some("lookup@test".to_string()), plugin_id: Some("lookup@test".to_string()),
@@ -2729,6 +2733,7 @@ fn mcp_server_status_serializes_absent_server_info_metadata_as_null() {
"websiteUrl": null, "websiteUrl": null,
}, },
"tools": {}, "tools": {},
"toolsError": null,
"resources": [], "resources": [],
"resourceTemplates": [], "resourceTemplates": [],
"authStatus": "unsupported", "authStatus": "unsupported",
+1 -1
View File
@@ -300,7 +300,7 @@ Example with notification opt-out:
- `mcpServer/oauth/login` — start an OAuth login for a configured MCP server; pass `threadId` to resolve servers from that thread's selected plugins and executor, optionally pass `clientRegistration` (`auto`, `cimd`, or `dcr`) to override client registration for this login only, and receive an `authorization_url` followed by `mcpServer/oauthLogin/completed` once the browser flow finishes. Omitting `clientRegistration` automatically discovers the authorization server's supported registration methods; the override is never persisted in server configuration. - `mcpServer/oauth/login` — start an OAuth login for a configured MCP server; pass `threadId` to resolve servers from that thread's selected plugins and executor, optionally pass `clientRegistration` (`auto`, `cimd`, or `dcr`) to override client registration for this login only, and receive an `authorization_url` followed by `mcpServer/oauthLogin/completed` once the browser flow finishes. Omitting `clientRegistration` automatically discovers the authorization server's supported registration methods; the override is never persisted in server configuration.
- `tool/requestUserInput` — prompt the user with 1–3 short questions for a tool call and return their answers (experimental). - `tool/requestUserInput` — prompt the user with 1–3 short questions for a tool call and return their answers (experimental).
- `config/mcpServer/reload` — reload MCP server config from disk and queue a refresh for loaded threads (applied on each thread's next active turn); returns `{}`. Use this after editing `config.toml` without restarting the server. - `config/mcpServer/reload` — reload MCP server config from disk and queue a refresh for loaded threads (applied on each thread's next active turn); returns `{}`. Use this after editing `config.toml` without restarting the server.
- `mcpServerStatus/list` — enumerate configured MCP servers with their tools, auth status, server info, owning `pluginId` (`null` for servers not contributed by a plugin), and nullable `runtimeStatus` from the current thread’s published connections, plus resources/resource templates for `full` detail; supports optional `threadId` and cursor+limit pagination. If `threadId` is omitted, the server reads from the latest global config directly and `runtimeStatus` is `null`. Runtime status is also `null` when the latest server registration differs from the thread’s published configuration. Runtime status is observed without starting or reconnecting the thread’s servers; it can be `notStarted`, `starting`, `connected`, `authenticationRequired`, `failed`, `cancelled`, or `disabled`. Inventory may be cached or collected separately and does not prove that the thread is connected. Older servers omit `runtimeStatus`; clients should treat that as unknown. If `detail` is omitted, the server defaults to `full`. An `unknown` auth status means OAuth support could not be determined; `unsupported` means OAuth is known not to be supported. - `mcpServerStatus/list` — enumerate configured MCP servers with their tools, auth status, server info, owning `pluginId` (`null` for servers not contributed by a plugin), and nullable `runtimeStatus` from the current thread’s published connections, plus resources/resource templates for `full` detail; supports optional `threadId` and cursor+limit pagination. If `threadId` is omitted, the server reads from the latest global config directly and `runtimeStatus` is `null`. Runtime status is also `null` when the latest server registration differs from the thread’s published configuration. Runtime status is observed without starting or reconnecting the thread’s servers; it can be `notStarted`, `starting`, `connected`, `authenticationRequired`, `failed`, `cancelled`, or `disabled`. Inventory may be cached or collected separately and does not prove that the thread is connected. Each server also includes nullable `toolsError`: a startup or tool-list discovery failure is reported when no catalog is returned. Returned catalogs, including cached or empty catalogs, have no error. Healthy servers are returned even when another server fails. Older servers omit `toolsError`; clients must preserve their existing behavior when it is absent. Older servers omit `runtimeStatus`; clients should treat that as unknown. If `detail` is omitted, the server defaults to `full`. An `unknown` auth status means OAuth support could not be determined; `unsupported` means OAuth is known not to be supported.
- `mcpServer/resource/read` — read a resource from a configured MCP server by optional `threadId`, `server`, and `uri`, returning text/blob resource `contents`. Pass `originCallId` with `threadId` to scope a Codex app widget to the app and account of the completed tool call that produced it; successful scoped reads return the same `originCallId`. Optional `connectorId` restricts other hosted app resources to their originating connector. If `threadId` is omitted, the server reads from the latest MCP config directly. - `mcpServer/resource/read` — read a resource from a configured MCP server by optional `threadId`, `server`, and `uri`, returning text/blob resource `contents`. Pass `originCallId` with `threadId` to scope a Codex app widget to the app and account of the completed tool call that produced it; successful scoped reads return the same `originCallId`. Optional `connectorId` restricts other hosted app resources to their originating connector. If `threadId` is omitted, the server reads from the latest MCP config directly.
- `mcpServer/event/stream/start` (experimental) — subscribe to an MCP event by `threadId`, `server`, `subscriptionId`, event `name`, `arguments`, and optional `_meta`. - `mcpServer/event/stream/start` (experimental) — subscribe to an MCP event by `threadId`, `server`, `subscriptionId`, event `name`, `arguments`, and optional `_meta`.
- `mcpServer/event/stream/stop` (experimental) — stop the caller's event subscription by `subscriptionId`. - `mcpServer/event/stream/stop` (experimental) — stop the caller's event subscription by `subscriptionId`.
@@ -343,6 +343,7 @@ impl McpRequestProcessor {
let McpServerStatusSnapshot { let McpServerStatusSnapshot {
server_infos, server_infos,
tools_by_server, tools_by_server,
tools_errors,
resources, resources,
resource_templates, resource_templates,
auth_statuses, auth_statuses,
@@ -396,6 +397,7 @@ impl McpRequestProcessor {
), ),
server_info: server_infos.get(name).cloned(), server_info: server_infos.get(name).cloned(),
tools: tools_by_server.get(name).cloned().unwrap_or_default(), tools: tools_by_server.get(name).cloned().unwrap_or_default(),
tools_error: tools_errors.get(name).cloned(),
resources: resources.get(name).cloned().unwrap_or_default(), resources: resources.get(name).cloned().unwrap_or_default(),
resource_templates: resource_templates.get(name).cloned().unwrap_or_default(), resource_templates: resource_templates.get(name).cloned().unwrap_or_default(),
auth_status: auth_statuses auth_status: auth_statuses
@@ -531,7 +531,15 @@ async fn mcp_server_status_list_returns_raw_server_and_tool_names() -> Result<()
let codex_home = TempDir::new()?; let codex_home = TempDir::new()?;
mock_responses_config(&server.uri()) mock_responses_config(&server.uri())
.with_extra_config(&format!( .with_extra_config(&format!(
"[mcp_servers.some-server]\nurl = \"{mcp_server_url}/mcp\"" "[mcp_servers.some-server]\nurl = \"{mcp_server_url}/mcp\"\n\
[mcp_servers.broken-server]\ncommand = {}",
toml::Value::String(
codex_home
.path()
.join("missing-mcp-server")
.display()
.to_string()
)
)) ))
.write(codex_home.path())?; .write(codex_home.path())?;
@@ -553,8 +561,25 @@ async fn mcp_server_status_list_returns_raw_server_and_tool_names() -> Result<()
.await?; .await?;
assert_eq!(response.next_cursor, None); assert_eq!(response.next_cursor, None);
assert_eq!(response.data.len(), 1); assert_eq!(response.data.len(), 2);
let status = &response.data[0]; let failed = response
.data
.iter()
.find(|status| status.name == "broken-server")
.unwrap();
assert!(failed.tools.is_empty());
assert!(
failed
.tools_error
.as_deref()
.is_some_and(|error| error.contains("MCP startup failed"))
);
let status = response
.data
.iter()
.find(|status| status.name == "some-server")
.unwrap();
assert_eq!(status.tools_error, None);
assert_eq!(status.name, "some-server"); assert_eq!(status.name, "some-server");
assert_eq!(status.runtime_status, None); assert_eq!(status.runtime_status, None);
assert_eq!(status.plugin_id, None); assert_eq!(status.plugin_id, None);
+2 -2
View File
@@ -171,10 +171,10 @@ impl McpServerView {
async fn listed_tools( async fn listed_tools(
&self, &self,
tool_plugin_provenance: &ToolPluginProvenance, tool_plugin_provenance: &ToolPluginProvenance,
) -> Option<Vec<ToolInfo>> { ) -> Result<Vec<ToolInfo>, StartupOutcomeError> {
let tools = self.connection.client.listed_tools().await?; let tools = self.connection.client.listed_tools().await?;
let tools = filter_tools(tools, &self.tool_filter); let tools = filter_tools(tools, &self.tool_filter);
Some(if self.connection.client.is_codex_apps_mcp_server { Ok(if self.connection.client.is_codex_apps_mcp_server {
prepare_codex_apps_tools_for_model(tools, tool_plugin_provenance) prepare_codex_apps_tools_for_model(tools, tool_plugin_provenance)
} else { } else {
prepare_regular_mcp_tools_for_model(tools, tool_plugin_provenance) prepare_regular_mcp_tools_for_model(tools, tool_plugin_provenance)
@@ -1,3 +1,4 @@
use std::collections::HashMap;
use std::collections::HashSet; use std::collections::HashSet;
use std::sync::Arc; use std::sync::Arc;
use std::sync::atomic::Ordering; use std::sync::atomic::Ordering;
@@ -83,9 +84,14 @@ impl McpConnectionSet {
} }
/// Returns all tools with model-visible names normalized. /// Returns all tools with model-visible names normalized.
#[instrument(level = "trace", skip_all, fields(mcp_server_count = self.servers.len()))]
pub async fn list_all_tools(&self) -> Vec<ToolInfo> { pub async fn list_all_tools(&self) -> Vec<ToolInfo> {
self.list_tools_with_errors().await.0
}
#[instrument(level = "trace", skip_all, fields(mcp_server_count = self.servers.len()))]
pub(crate) async fn list_tools_with_errors(&self) -> (Vec<ToolInfo>, HashMap<String, String>) {
let mut tools = Vec::new(); let mut tools = Vec::new();
let mut errors = HashMap::new();
let mut available_server_count = 0; let mut available_server_count = 0;
let mut unavailable_server_count = 0; let mut unavailable_server_count = 0;
let server_results = join_all(self.servers.iter().map(|(server_name, view)| async move { let server_results = join_all(self.servers.iter().map(|(server_name, view)| async move {
@@ -105,7 +111,7 @@ impl McpConnectionSet {
match catalog_override { match catalog_override {
Some(tools) => { Some(tools) => {
let tools = filter_tools(tools, &view.tool_filter); let tools = filter_tools(tools, &view.tool_filter);
Some(prepare_codex_apps_tools_for_model( Ok(prepare_codex_apps_tools_for_model(
tools, tools,
&self.tool_plugin_provenance, &self.tool_plugin_provenance,
)) ))
@@ -120,32 +126,34 @@ impl McpConnectionSet {
startup_complete startup_complete
)) ))
.await; .await;
match server_tools { let result = match server_tools {
Some(server_tools) => Some( Ok(server_tools) => Ok(server_tools
server_tools .into_iter()
.into_iter() .map(|tool| Self::with_server_metadata(tool, &view.metadata))
.map(|tool| Self::with_server_metadata(tool, &view.metadata)) .collect::<Vec<_>>()),
.collect::<Vec<_>>(), Err(error) => {
),
None => {
trace!( trace!(
server_name = %server_name, server_name = %server_name,
has_cached_tools, has_cached_tools,
startup_complete, startup_complete,
"MCP server tools unavailable while building tool list" "MCP server tools unavailable while building tool list"
); );
None Err(error)
} }
} };
(server_name, result)
})) }))
.await; .await;
for server_tools in server_results { for (server_name, server_tools) in server_results {
match server_tools { match server_tools {
Some(server_tools) => { Ok(server_tools) => {
available_server_count += 1; available_server_count += 1;
tools.extend(server_tools); tools.extend(server_tools);
} }
None => unavailable_server_count += 1, Err(error) => {
unavailable_server_count += 1;
errors.insert(server_name.clone(), error.to_string());
}
} }
} }
let tools = normalize_tools_for_model_with_prefix( let tools = normalize_tools_for_model_with_prefix(
@@ -159,7 +167,7 @@ impl McpConnectionSet {
tool_count = tools.len(), tool_count = tools.len(),
"built MCP tool list" "built MCP tool list"
); );
tools (tools, errors)
} }
#[expect( #[expect(
+5 -2
View File
@@ -459,6 +459,7 @@ pub async fn read_mcp_resource(
pub struct McpServerStatusSnapshot { pub struct McpServerStatusSnapshot {
pub server_infos: HashMap<String, McpServerInfo>, pub server_infos: HashMap<String, McpServerInfo>,
pub tools_by_server: HashMap<String, HashMap<String, Tool>>, pub tools_by_server: HashMap<String, HashMap<String, Tool>>,
pub tools_errors: HashMap<String, String>,
pub resources: HashMap<String, Vec<Resource>>, pub resources: HashMap<String, Vec<Resource>>,
pub resource_templates: HashMap<String, Vec<ResourceTemplate>>, pub resource_templates: HashMap<String, Vec<ResourceTemplate>>,
pub auth_statuses: HashMap<String, McpAuthStatus>, pub auth_statuses: HashMap<String, McpAuthStatus>,
@@ -479,6 +480,7 @@ pub async fn collect_mcp_server_status_snapshot_with_detail(
return McpServerStatusSnapshot { return McpServerStatusSnapshot {
server_infos: HashMap::new(), server_infos: HashMap::new(),
tools_by_server: HashMap::new(), tools_by_server: HashMap::new(),
tools_errors: HashMap::new(),
resources: HashMap::new(), resources: HashMap::new(),
resource_templates: HashMap::new(), resource_templates: HashMap::new(),
auth_statuses: HashMap::new(), auth_statuses: HashMap::new(),
@@ -761,10 +763,10 @@ async fn collect_mcp_server_status_snapshot_from_manager(
server_names: Vec<String>, server_names: Vec<String>,
detail: McpSnapshotDetail, detail: McpSnapshotDetail,
) -> McpServerStatusSnapshot { ) -> McpServerStatusSnapshot {
let ((server_infos, tools), resources, resource_templates) = tokio::join!( let ((server_infos, (tools, tools_errors)), resources, resource_templates) = tokio::join!(
async { async {
let server_infos = mcp_connection_manager.list_available_server_infos().await; let server_infos = mcp_connection_manager.list_available_server_infos().await;
let tools = mcp_connection_manager.list_all_tools().await; let tools = mcp_connection_manager.list_tools_with_errors().await;
(server_infos, tools) (server_infos, tools)
}, },
async { async {
@@ -801,6 +803,7 @@ async fn collect_mcp_server_status_snapshot_from_manager(
McpServerStatusSnapshot { McpServerStatusSnapshot {
server_infos, server_infos,
tools_by_server, tools_by_server,
tools_errors,
resources: convert_mcp_resources(resources), resources: convert_mcp_resources(resources),
resource_templates: convert_mcp_resource_templates(resource_templates), resource_templates: convert_mcp_resource_templates(resource_templates),
auth_statuses: auth_statuses_from_entries(&auth_status_entries), auth_statuses: auth_statuses_from_entries(&auth_status_entries),
+5 -5
View File
@@ -577,17 +577,17 @@ impl AsyncManagedClient {
}) })
} }
pub(crate) async fn listed_tools(&self) -> Option<Vec<ToolInfo>> { pub(crate) async fn listed_tools(&self) -> Result<Vec<ToolInfo>, StartupOutcomeError> {
// Plugin provenance is resolved per-session rather than stored in shared cache payloads. // Plugin provenance is resolved per-session rather than stored in shared cache payloads.
if !self.startup_complete.load(Ordering::Acquire) if !self.startup_complete.load(Ordering::Acquire)
&& let Some(startup_tools) = self.cached_tools() && let Some(startup_tools) = self.cached_tools()
{ {
Some(startup_tools) Ok(startup_tools)
} else { } else {
match self.client().await { match self.client().await {
Ok(client) => Some(client.listed_tools()), Ok(client) => Ok(client.listed_tools()),
Err(_) if self.is_codex_apps_mcp_server => self.cached_tools(), Err(error) if self.is_codex_apps_mcp_server => self.cached_tools().ok_or(error),
Err(_) => None, Err(error) => Err(error),
} }
} }
} }
@@ -1591,6 +1591,7 @@ mod tests {
fn mcp_inventory_maps_prefix_tool_names_by_server() { fn mcp_inventory_maps_prefix_tool_names_by_server() {
let statuses = vec![ let statuses = vec![
McpServerStatus { McpServerStatus {
tools_error: None,
name: "docs".to_string(), name: "docs".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
@@ -1613,6 +1614,7 @@ mod tests {
auth_status: codex_app_server_protocol::McpAuthStatus::Unsupported, auth_status: codex_app_server_protocol::McpAuthStatus::Unsupported,
}, },
McpServerStatus { McpServerStatus {
tools_error: None,
name: "disabled".to_string(), name: "disabled".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
+1
View File
@@ -278,6 +278,7 @@ async fn handle_mcp_inventory_result_respects_origin_thread() {
app.handle_mcp_inventory_result( app.handle_mcp_inventory_result(
Ok(vec![McpServerStatus { Ok(vec![McpServerStatus {
tools_error: None,
name: "docs".to_string(), name: "docs".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
@@ -28,6 +28,7 @@ fn mcp_inventory_connection_states() {
plugin_id: None, plugin_id: None,
server_info: None, server_info: None,
tools: HashMap::new(), tools: HashMap::new(),
tools_error: None,
resources: Vec::new(), resources: Vec::new(),
resource_templates: Vec::new(), resource_templates: Vec::new(),
auth_status: McpAuthStatus::Unknown, auth_status: McpAuthStatus::Unknown,
+2
View File
@@ -987,6 +987,7 @@ async fn mcp_tools_output_lists_tools_for_hyphenated_server_names() {
#[test] #[test]
fn mcp_tools_output_from_statuses_renders_status_only_servers() { fn mcp_tools_output_from_statuses_renders_status_only_servers() {
let statuses = vec![McpServerStatus { let statuses = vec![McpServerStatus {
tools_error: None,
name: "plugin_docs".to_string(), name: "plugin_docs".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,
@@ -1019,6 +1020,7 @@ fn mcp_tools_output_from_statuses_renders_status_only_servers() {
#[test] #[test]
fn mcp_tools_output_from_statuses_renders_verbose_inventory() { fn mcp_tools_output_from_statuses_renders_verbose_inventory() {
let statuses = vec![McpServerStatus { let statuses = vec![McpServerStatus {
tools_error: None,
name: "plugin_docs".to_string(), name: "plugin_docs".to_string(),
runtime_status: None, runtime_status: None,
plugin_id: None, plugin_id: None,