github/codex
4
0 Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-13 14:46:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Restrict plugin migration to home scope (#39663)

Browse Source 
## Why

Plugin imports persist user-global enabled state. Repository-controlled settings
must not be allowed to select executable plugin content for installation.

## What changed

- Detect plugin migrations only from home-scoped external agent settings.
- Reject plugin imports with a non-empty project `cwd` before loading Codex
  configuration, while continuing to treat an empty `cwd` as home scope.

## Testing

- Cover repository-scoped detection with remote, installed, and project-relative
  marketplaces.
- Verify that forged project-scoped imports fail without writing `config.toml`.

GitOrigin-RevId: 53cb46ae049cb49283187312d475d40cf42e35ab
This commit is contained in:
charlesgong-openai authored and copyberry committed 2026-08-20 08:24:18 +00:00
1 parent 240bbfc14a
commit 97c82c0900
4 files changed
+74 -115
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

codex-rs/external-agent-migration/src/detect/mod.rs
+3 -1
View File
@@ -327,7 +327,9 @@ impl ExternalAgentConfigService {
);
}
if self.source.supports_plugin_migration(settings.as_ref()) {
// Plugin import persists user-global enabled state, so repository-controlled
// settings must never be treated as plugin installation authority.
if scope.is_home() && self.source.supports_plugin_migration(settings.as_ref()) {
match ConfigBuilder::default()
.codex_home(self.codex_home.clone())
.fallback_cwd(Some(self.codex_home.clone()))