mirror of
https://github.com/openai/codex.git
synced 2026-11-21 15:10:25 +00:00
Preserve acceptance order in retained thread context (#42770)
## Why Queued prompts and `request_user_input` answers can be persisted in a different order from when the host accepted them. Using persistence order can therefore reorder retained instructions during replay or apply the wrong rollback boundary. ## What changed - Reserve an acceptance sequence for user prompts and elicitation responses when retained thread context is enabled. - Persist that sequence with user-message metadata and verified answers, and use it when ordering, bounding, replaying, and rolling back retained context. - Keep events without acceptance metadata compatible with legacy recording order. ## Testing - Cover delayed queued-input recording, rejected prompts, checkpoint replay, compaction, rollback migration, and legacy retained-context behavior. GitOrigin-RevId: 42d24465cc2033bc51c0c2da79d3c0884a8ad98a
This commit is contained in:
1 parent
88f87d907a
commit
99d66aa1c5
24 files changed
+489
-152
No files matched your search
@@ -1620,7 +1620,7 @@ pub(crate) async fn request_mcp_tool_user_approval(
|
||||
.request_user_input(turn_context, call_id.to_string(), args)
|
||||
.await;
|
||||
normalize_approval_decision_for_mode(
|
||||
parse_mcp_tool_approval_response(response, &question_id),
|
||||
parse_mcp_tool_approval_response(response.map(|accepted| accepted.response), &question_id),
|
||||
*approval_mode,
|
||||
)
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user