mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Separate TUI preferences from server configuration (#42202)
## Why TUI preferences and persistence paths belong to the local client, while thread configuration and account requirements may come from the active app server. Keeping both in the same resolved `Config` can replace live local preferences when a thread is resumed, forked, reconnected, or switched. ## What changed - Add `LocalSettings` as the TUI-owned source for UI, history, notice, and local persistence settings, and preserve it across session lifecycle transitions. - Write preference changes to the selected user config file and reload local settings from disk when changing roots. - Use the app server's account response for authentication-dependent onboarding and status UI instead of the local model-provider configuration. - Retain platform family and OS metadata reported by remote app servers. ## Testing - Cover local setting defaults, overrides, persistence destinations, reloads, and preservation across widget replacement and root switching. - Cover remote platform metadata and server-controlled authentication UI. GitOrigin-RevId: dbc2965fb1d6cbecb3f973f6133f3dcd4467b753
This commit is contained in:
1 parent
0b509e930e
commit
9d57be71ba
87 files changed
+1188
-459
No files matched your search
@@ -536,8 +536,9 @@ pub(crate) struct App {
|
||||
pub(crate) app_event_tx: AppEventSender,
|
||||
pub(crate) chat_widget: ChatWidget,
|
||||
workspace_command_runner: Option<WorkspaceCommandRunner>,
|
||||
/// Config is stored here so we can recreate ChatWidgets as needed.
|
||||
/// Legacy bootstrap and server-setting inputs; local preferences live in `local_settings`.
|
||||
pub(crate) config: Config,
|
||||
pub(crate) local_settings: crate::local_settings::LocalSettings,
|
||||
launch_cwd: PathBuf,
|
||||
/// Resume anchor selected by `/cd`; ordinary resumes retain the immutable launch cwd.
|
||||
runtime_working_directory_override: Option<PathBuf>,
|
||||
@@ -779,6 +780,7 @@ impl App {
|
||||
initial_user_message: Option<crate::chatwidget::UserMessage>,
|
||||
) -> crate::chatwidget::ChatWidgetInit {
|
||||
crate::chatwidget::ChatWidgetInit {
|
||||
local_settings: self.local_settings.clone(),
|
||||
config: cfg,
|
||||
frame_requester: tui.frame_requester(),
|
||||
app_event_tx: self.app_event_tx.clone(),
|
||||
@@ -786,6 +788,7 @@ impl App {
|
||||
initial_user_message,
|
||||
enhanced_keys_supported: self.enhanced_keys_supported,
|
||||
has_chatgpt_account: self.chat_widget.has_chatgpt_account(),
|
||||
requires_openai_auth: self.chat_widget.requires_openai_auth,
|
||||
has_codex_backend_auth: self.chat_widget.has_codex_backend_auth(),
|
||||
model_catalog: self.model_catalog.clone(),
|
||||
feedback: self.feedback.clone(),
|
||||
|
||||
Reference in new issue
Block a user