mirror of
https://github.com/openai/codex.git
synced 2026-11-19 23:05:23 +00:00
Improve automatic thread naming in the TUI (#42749)
## Why Automatic title generation used a provisional thread name and only applied the generated result while its thread remained active. Switching threads could therefore leave the originating thread without its generated name. ## What changed - Track title-generation requests by thread so results are persisted for the originating thread, while preserving any name set before generation finishes. - Show a `renaming...` spinner instead of a provisional name, including across thread switches and failure paths. - Add `thread-name` items to the status line and terminal title, and include the generated thread name in both default layouts. ## Testing - Cover automatic naming, manual-name precedence, thread switching, failed requests, deduplication, and status-surface rendering and animation. GitOrigin-RevId: a03ae4849bedec9f62f256fadad72c1685ce46e0
This commit is contained in:
1 parent
8e85265c39
commit
a1294e57f1
32 files changed
+642
-181
No files matched your search
@@ -2582,16 +2582,20 @@ impl App {
|
||||
self.temporary_structured_requests
|
||||
.remove(&temporary_thread_id);
|
||||
|
||||
self.finish_thread_title_generation(thread_id, destination);
|
||||
match destination {
|
||||
ThreadTitleDestination::Automatic { expected_title } => {
|
||||
ThreadTitleDestination::Automatic => {
|
||||
if let Ok(response) = result
|
||||
&& let Some(title) = super::thread_title::parse_thread_title(&response)
|
||||
&& self.chat_widget.thread_id() == Some(thread_id)
|
||||
&& self.chat_widget.thread_name().as_deref()
|
||||
== Some(expected_title.as_str())
|
||||
&& let Ok(thread) = app_server
|
||||
.thread_read(thread_id, /*include_turns*/ false)
|
||||
.await
|
||||
&& thread.name.is_none()
|
||||
{
|
||||
match app_server.thread_set_name(thread_id, title.clone()).await {
|
||||
Ok(()) => self.chat_widget.expect_automatic_thread_name(title),
|
||||
Ok(()) => self
|
||||
.chat_widget
|
||||
.on_thread_name_updated(thread_id, Some(title)),
|
||||
Err(error) => {
|
||||
tracing::debug!(%error, "failed to apply generated thread title");
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user