mirror of
https://github.com/openai/codex.git
synced 2026-11-20 07:06:24 +00:00
Improve automatic thread naming in the TUI (#42749)
## Why Automatic title generation used a provisional thread name and only applied the generated result while its thread remained active. Switching threads could therefore leave the originating thread without its generated name. ## What changed - Track title-generation requests by thread so results are persisted for the originating thread, while preserving any name set before generation finishes. - Show a `renaming...` spinner instead of a provisional name, including across thread switches and failure paths. - Add `thread-name` items to the status line and terminal title, and include the generated thread name in both default layouts. ## Testing - Cover automatic naming, manual-name precedence, thread switching, failed requests, deduplication, and status-surface rendering and animation. GitOrigin-RevId: a03ae4849bedec9f62f256fadad72c1685ce46e0
This commit is contained in:
1 parent
8e85265c39
commit
a1294e57f1
32 files changed
+642
-181
No files matched your search
@@ -30,7 +30,6 @@ impl ChatWidget {
|
||||
self.backend_banner_notice_model = None;
|
||||
self.automatic_model_switch_state =
|
||||
backend_banners::AutomaticModelSwitchState::default();
|
||||
self.pending_automatic_thread_names.clear();
|
||||
self.review.recent_auto_review_denials = RecentAutoReviewDenials::default();
|
||||
self.clear_thread_usage_state();
|
||||
}
|
||||
@@ -265,13 +264,7 @@ impl ChatWidget {
|
||||
)));
|
||||
}
|
||||
|
||||
/// Apply a persisted automatic name immediately and suppress its confirmation.
|
||||
pub(crate) fn expect_automatic_thread_name(&mut self, name: String) {
|
||||
self.thread_name = Some(name.clone());
|
||||
self.pending_automatic_thread_names.insert(name);
|
||||
}
|
||||
|
||||
/// Make a confirmed manual rename visible before its queued server notification arrives.
|
||||
/// Update status surfaces before a confirmed manual rename's server notification arrives.
|
||||
pub(crate) fn expect_manual_thread_name(&mut self, thread_id: ThreadId, name: String) {
|
||||
if self.thread_id == Some(thread_id) {
|
||||
self.thread_name = Some(name);
|
||||
@@ -280,23 +273,13 @@ impl ChatWidget {
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn on_thread_name_updated(
|
||||
/// Update name metadata silently, including late and replayed notifications.
|
||||
pub(crate) fn on_thread_name_updated(
|
||||
&mut self,
|
||||
thread_id: ThreadId,
|
||||
thread_name: Option<String>,
|
||||
) {
|
||||
if self.thread_id == Some(thread_id) {
|
||||
let automatic = thread_name
|
||||
.as_ref()
|
||||
.is_some_and(|name| self.pending_automatic_thread_names.remove(name));
|
||||
|
||||
if let Some(name) = thread_name.as_deref()
|
||||
&& !automatic
|
||||
{
|
||||
let cell = Self::rename_confirmation_cell(name, self.thread_id);
|
||||
self.add_boxed_history(Box::new(cell));
|
||||
}
|
||||
|
||||
self.thread_name = thread_name;
|
||||
self.refresh_status_surfaces();
|
||||
self.request_redraw();
|
||||
|
||||
Reference in new issue
Block a user