From a2fb3f048d07cdb44a2de833a1757c21a24893bf Mon Sep 17 00:00:00 2001 From: iceweasel-oai Date: Tue, 14 Jul 2026 21:03:49 +0000 Subject: [PATCH] Document the Windows exec yield time range (#33167) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## What changed Document that `exec_command.yield_time_ms` has an effective range of 2,000–30,000 ms on Windows, and update the tool specification test to match. GitOrigin-RevId: aa20bbb2ad82d162d29d93f3bfbe1b970445f44e --- codex-rs/core/src/tools/handlers/shell_spec.rs | 2 +- codex-rs/core/src/tools/handlers/shell_spec_tests.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/codex-rs/core/src/tools/handlers/shell_spec.rs b/codex-rs/core/src/tools/handlers/shell_spec.rs index 69a7946523..8ef9af9083 100644 --- a/codex-rs/core/src/tools/handlers/shell_spec.rs +++ b/codex-rs/core/src/tools/handlers/shell_spec.rs @@ -24,7 +24,7 @@ pub(crate) fn create_exec_command_tool_with_environment_id( include_shell_parameter: bool, ) -> ToolSpec { let yield_time_ms_description = if cfg!(windows) { - "Maximum time to wait before returning a session ID for a still-running command. Commands that finish sooner return immediately. For ordinary commands, omit this parameter to use the 10000 ms default. Set a shorter value only when intentionally starting a long-lived or interactive process and you want a session ID promptly." + "Maximum time to wait before returning a session ID for a still-running command. Commands that finish sooner return immediately. For ordinary commands, omit this parameter to use the 10000 ms default. Effective range on Windows is 2000-30000 ms. Set a shorter value only when intentionally starting a long-lived or interactive process and you want a session ID promptly." } else { "Wait before yielding output. Defaults to 10000 ms; effective range is 250-30000 ms." }; diff --git a/codex-rs/core/src/tools/handlers/shell_spec_tests.rs b/codex-rs/core/src/tools/handlers/shell_spec_tests.rs index cb73d45421..441d93a89d 100644 --- a/codex-rs/core/src/tools/handlers/shell_spec_tests.rs +++ b/codex-rs/core/src/tools/handlers/shell_spec_tests.rs @@ -30,7 +30,7 @@ fn exec_command_tool_matches_expected_spec() { .to_string() }; let yield_time_ms_description = if cfg!(windows) { - "Maximum time to wait before returning a session ID for a still-running command. Commands that finish sooner return immediately. For ordinary commands, omit this parameter to use the 10000 ms default. Set a shorter value only when intentionally starting a long-lived or interactive process and you want a session ID promptly." + "Maximum time to wait before returning a session ID for a still-running command. Commands that finish sooner return immediately. For ordinary commands, omit this parameter to use the 10000 ms default. Effective range on Windows is 2000-30000 ms. Set a shorter value only when intentionally starting a long-lived or interactive process and you want a session ID promptly." } else { "Wait before yielding output. Defaults to 10000 ms; effective range is 250-30000 ms." };