mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Preserve Guardian parent response IDs across sampling requests (#45441)
## Why Running code-mode cells can request Guardian review while the next response is in flight. Clearing the response ID before that response emits `response.created` leaves those reviews without a `parent_response_id`. ## What changed Keep the latest response ID received in the turn until a later `response.created` replaces it, including across sampling retries. ## Testing Add regression coverage for reviews before and after a response handoff and for a fresh turn that must not inherit the previous turn's ID. Update retry coverage to expect the last known parent when the retry supplies no response ID. GitOrigin-RevId: af0a08de09edad59e1a7ade7904a42d616b05679
This commit is contained in:
1 parent
f8bed26f7b
commit
b6a5d5bb14
5 files changed
+203
-13
No files matched your search
@@ -78,7 +78,7 @@ pub(crate) const GUARDIAN_MAX_NODE_REPL_TOOL_RESULT_TOKENS: usize = 6_000;
|
||||
/// MCP elicitation reviews continue to use turn-only inputs.
|
||||
#[derive(Clone)]
|
||||
pub(crate) struct GuardianReviewContext {
|
||||
/// The response currently handled in this execution context.
|
||||
/// The latest response ID received in this turn when review was requested.
|
||||
pub(crate) parent_response_id: Option<String>,
|
||||
turn: Arc<TurnContext>,
|
||||
environments: TurnEnvironmentSnapshot,
|
||||
|
||||
Reference in new issue
Block a user