Apply argument comment lint across codex-rs (#14652)

## Why

Once the repo-local lint exists, `codex-rs` needs to follow the
checked-in convention and CI needs to keep it from drifting. This commit
applies the fallback `/*param*/` style consistently across existing
positional literal call sites without changing those APIs.

The longer-term preference is still to avoid APIs that require comments
by choosing clearer parameter types and call shapes. This PR is
intentionally the mechanical follow-through for the places where the
existing signatures stay in place.

After rebasing onto newer `main`, the rollout also had to cover newly
introduced `tui_app_server` call sites. That made it clear the first cut
of the CI job was too expensive for the common path: it was spending
almost as much time installing `cargo-dylint` and re-testing the lint
crate as a representative test job spends running product tests. The CI
update keeps the full workspace enforcement but trims that extra
overhead from ordinary `codex-rs` PRs.

## What changed

- keep a dedicated `argument_comment_lint` job in `rust-ci`
- mechanically annotate remaining opaque positional literals across
`codex-rs` with exact `/*param*/` comments, including the rebased
`tui_app_server` call sites that now fall under the lint
- keep the checked-in style aligned with the lint policy by using
`/*param*/` and leaving string and char literals uncommented
- cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
registry/git metadata in the lint job
- split changed-path detection so the lint crate's own `cargo test` step
runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
- continue to run the repo wrapper over the `codex-rs` workspace, so
product-code enforcement is unchanged

Most of the code changes in this commit are intentionally mechanical
comment rewrites or insertions driven by the lint itself.

## Verification

- `./tools/argument-comment-lint/run.sh --workspace`
- `cargo test -p codex-tui-app-server -p codex-tui`
- parsed `.github/workflows/rust-ci.yml` locally with PyYAML

---

* -> #14652
* #14651
This commit is contained in:
Michael Bolin authored and GitHub committed 2026-03-16 16:48:15 -07:00
1 parent 6f05d8d735
commit b77fe8fefe
261 files changed
+2311 -1377

No files matched your search

+2 -2
View File
@@ -97,7 +97,7 @@ pub(in crate::memories) async fn run(session: &Arc<Session>, config: &Config) {
if claimed_candidates.is_empty() {
session.services.session_telemetry.counter(
metrics::MEMORY_PHASE_ONE_JOBS,
1,
/*inc*/ 1,
&[("status", "skipped_no_candidates")],
);
return;
@@ -211,7 +211,7 @@ async fn claim_startup_jobs(
warn!("state db claim_stage1_jobs_for_startup failed during memories startup: {err}");
session.services.session_telemetry.counter(
metrics::MEMORY_PHASE_ONE_JOBS,
1,
/*inc*/ 1,
&[("status", "failed_claim")],
);
None
+5 -5
View File
@@ -61,7 +61,7 @@ pub(super) async fn run(session: &Arc<Session>, config: Arc<Config>) {
Err(e) => {
session.services.session_telemetry.counter(
metrics::MEMORY_PHASE_TWO_JOBS,
1,
/*inc*/ 1,
&[("status", e)],
);
return;
@@ -198,7 +198,7 @@ mod job {
} => {
session_telemetry.counter(
metrics::MEMORY_PHASE_TWO_JOBS,
1,
/*inc*/ 1,
&[("status", "claimed")],
);
(ownership_token, input_watermark)
@@ -218,7 +218,7 @@ mod job {
) {
session.services.session_telemetry.counter(
metrics::MEMORY_PHASE_TWO_JOBS,
1,
/*inc*/ 1,
&[("status", reason)],
);
if matches!(
@@ -250,7 +250,7 @@ mod job {
) {
session.services.session_telemetry.counter(
metrics::MEMORY_PHASE_TWO_JOBS,
1,
/*inc*/ 1,
&[("status", reason)],
);
let _ = db
@@ -462,7 +462,7 @@ fn emit_metrics(session: &Arc<Session>, counters: Counters) {
otel.counter(
metrics::MEMORY_PHASE_TWO_JOBS,
1,
/*inc*/ 1,
&[("status", "agent_spawned")],
);
}
+1 -1
View File
@@ -41,7 +41,7 @@ pub(crate) async fn emit_metric_for_tool_read(invocation: &ToolInvocation, succe
for kind in kinds {
invocation.turn.session_telemetry.counter(
MEMORIES_USAGE_METRIC,
1,
/*inc*/ 1,
&[
("kind", kind.as_tag()),
("tool", invocation.tool_name.as_str()),