From ba42e6866cef4baed7ad92c73e6be8cd42e49d8b Mon Sep 17 00:00:00 2001 From: mandal-OAI Date: Thu, 30 Jul 2026 17:05:53 +0000 Subject: [PATCH] Label explicit skill injection metrics (#36191) ## Why The `codex.skill.injected` counter needs to distinguish explicitly requested skills from implicitly invoked skills. ## What changed Add the `invoke_type=explicit` attribute to skill injection metrics emitted for explicit skill mentions, including both successful and failed injections. GitOrigin-RevId: 22023f8d628be0f22b23f5376b668e8d5492c14a --- codex-rs/core-skills/src/injection.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/codex-rs/core-skills/src/injection.rs b/codex-rs/core-skills/src/injection.rs index 2a243b9ee9..2529526496 100644 --- a/codex-rs/core-skills/src/injection.rs +++ b/codex-rs/core-skills/src/injection.rs @@ -142,7 +142,11 @@ fn emit_skill_injected_metric( otel.counter( "codex.skill.injected", /*inc*/ 1, - &[("status", status), ("skill", skill_name_tag.as_str())], + &[ + ("status", status), + ("skill", skill_name_tag.as_str()), + ("invoke_type", "explicit"), + ], ); }