mirror of
https://github.com/openai/codex.git
synced 2026-11-18 07:00:27 +00:00
Update Windows process-tree tests for inherited FDs (#34640)
## Why The PTY and pipe spawn helpers now require callers to specify which file descriptors should be inherited, following https://github.com/openai/codex/pull/13644. ## What changed Pass empty inherited-FD slices from the Windows process-tree tests, which do not need to preserve any file descriptors. GitOrigin-RevId: 5e578df34e195251490608a163f8aaee0a6e681c
This commit is contained in:
1 parent
81de4f251c
commit
bdd3118c71
1 file changed
+4
-2
@@ -79,7 +79,7 @@ async fn assert_terminate_kills_descendant(
|
|||||||
);
|
);
|
||||||
let args = vec!["-u".to_string(), "-c".to_string(), code];
|
let args = vec!["-u".to_string(), "-c".to_string(), code];
|
||||||
let spawned = if backend == "pipe" {
|
let spawned = if backend == "pipe" {
|
||||||
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await?
|
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await?
|
||||||
} else {
|
} else {
|
||||||
spawn_pty_process(
|
spawn_pty_process(
|
||||||
python,
|
python,
|
||||||
@@ -88,6 +88,7 @@ async fn assert_terminate_kills_descendant(
|
|||||||
env,
|
env,
|
||||||
/*arg0*/ &None,
|
/*arg0*/ &None,
|
||||||
TerminalSize::default(),
|
TerminalSize::default(),
|
||||||
|
&[],
|
||||||
)
|
)
|
||||||
.await?
|
.await?
|
||||||
};
|
};
|
||||||
@@ -134,7 +135,7 @@ async fn assert_normal_exit_preserves_descendant(
|
|||||||
);
|
);
|
||||||
let args = vec!["-u".to_string(), "-c".to_string(), code];
|
let args = vec!["-u".to_string(), "-c".to_string(), code];
|
||||||
let spawned = if backend == "pipe" {
|
let spawned = if backend == "pipe" {
|
||||||
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await?
|
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await?
|
||||||
} else {
|
} else {
|
||||||
spawn_pty_process(
|
spawn_pty_process(
|
||||||
python,
|
python,
|
||||||
@@ -143,6 +144,7 @@ async fn assert_normal_exit_preserves_descendant(
|
|||||||
env,
|
env,
|
||||||
/*arg0*/ &None,
|
/*arg0*/ &None,
|
||||||
TerminalSize::default(),
|
TerminalSize::default(),
|
||||||
|
&[],
|
||||||
)
|
)
|
||||||
.await?
|
.await?
|
||||||
};
|
};
|
||||||
|
|||||||
Reference in new issue
Block a user