Remove obsolete plugin skill discovery helpers (#37832)

## What changed

- Remove the path-only `effective_skill_roots` API and its type-erasing trait in favor of `effective_plugin_skill_roots`, which preserves plugin metadata.
- Remove skill-path ancestor lookup helpers and keep namespace resolution scoped to an explicit plugin root.
- Update plugin manager and namespace tests to exercise the retained APIs directly.

GitOrigin-RevId: 507bf43bc6147bb5ab2deba4fa176bea2535159c
This commit is contained in:
felixxia-oai authored and copyberry committed 2026-08-10 14:25:13 +00:00
1 parent d109393270
commit bfb7790eb3
5 files changed
+24 -66

No files matched your search

+7 -3
View File
@@ -991,7 +991,11 @@ async fn load_plugins_loads_default_skills_and_mcp_servers() {
}]
);
assert_eq!(
outcome.effective_skill_roots(),
outcome
.effective_plugin_skill_roots()
.into_iter()
.map(|root| root.path)
.collect::<Vec<_>>(),
vec![plugin_root.join("skills").abs()]
);
assert_eq!(outcome.effective_mcp_servers().len(), 1);
@@ -2596,7 +2600,7 @@ async fn load_plugins_preserves_disabled_plugins_without_effective_contributions
error: None,
}]
);
assert!(outcome.effective_skill_roots().is_empty());
assert!(outcome.effective_plugin_skill_roots().is_empty());
assert!(outcome.effective_mcp_servers().is_empty());
}
@@ -3086,7 +3090,7 @@ async fn load_plugins_rejects_invalid_plugin_keys() {
outcome.plugins()[0].error.as_deref(),
Some("invalid plugin key `sample`; expected <plugin>@<marketplace>")
);
assert!(outcome.effective_skill_roots().is_empty());
assert!(outcome.effective_plugin_skill_roots().is_empty());
assert!(outcome.effective_mcp_servers().is_empty());
}