remove unnecessary todos (#8842)

> // todo(aibrahim): why are we passing model here while it can change?

we update it on each turn with `.with_model`

> //TODO(aibrahim): run CI in release mode.

although it's good to have, release builds take double the time tests
take.

> // todo(aibrahim): make this async function

we figured out another way of doing this sync

codex-rs/core/src/codex.rs

@@ -643,7 +643,6 @@ impl Session {
         }
         maybe_push_chat_wire_api_deprecation(&config, &mut post_session_configured_events);
 
-        // todo(aibrahim): why are we passing model here while it can change?
         let otel_manager = OtelManager::new(
             conversation_id,
             session_configuration.model.as_str(),

codex-rs/core/src/context_manager/history_tests.rs

@@ -593,7 +593,6 @@ fn format_exec_output_prefers_line_marker_when_both_limits_exceeded() {
     assert_truncated_message_matches(&truncated, "line-0-", 17_423);
 }
 
-//TODO(aibrahim): run CI in release mode.
 #[cfg(not(debug_assertions))]
 #[test]
 fn normalize_adds_missing_output_for_function_call() {

codex-rs/tui/src/chatwidget.rs

@@ -2440,19 +2440,16 @@ impl ChatWidget {
     /// Open a popup to choose a quick auto model. Selecting "All models"
     /// opens the full picker with every available preset.
     pub(crate) fn open_model_popup(&mut self) {
-        let presets: Vec<ModelPreset> =
+        let presets: Vec<ModelPreset> = match self.models_manager.try_list_models(&self.config) {
-            // todo(aibrahim): make this async function
+            Ok(models) => models,
-            match self.models_manager.try_list_models(&self.config) {
+            Err(_) => {
-                Ok(models) => models,
+                self.add_info_message(
-                Err(_) => {
+                    "Models are being updated; please try /model again in a moment.".to_string(),
-                    self.add_info_message(
+                    None,
-                        "Models are being updated; please try /model again in a moment."
+                );
-                            .to_string(),
+                return;
-                        None,
+            }
-                    );
+        };
-                    return;
-                }
-            };
         self.open_model_popup_with_presets(presets);
     }
 

codex-rs/tui2/src/chatwidget.rs

@@ -2236,19 +2236,16 @@ impl ChatWidget {
     /// Open a popup to choose a quick auto model. Selecting "All models"
     /// opens the full picker with every available preset.
     pub(crate) fn open_model_popup(&mut self) {
-        let presets: Vec<ModelPreset> =
+        let presets: Vec<ModelPreset> = match self.models_manager.try_list_models(&self.config) {
-            // todo(aibrahim): make this async function
+            Ok(models) => models,
-            match self.models_manager.try_list_models(&self.config) {
+            Err(_) => {
-                Ok(models) => models,
+                self.add_info_message(
-                Err(_) => {
+                    "Models are being updated; please try /model again in a moment.".to_string(),
-                    self.add_info_message(
+                    None,
-                        "Models are being updated; please try /model again in a moment."
+                );
-                            .to_string(),
+                return;
-                        None,
+            }
-                    );
+        };
-                    return;
-                }
-            };
         self.open_model_popup_with_presets(presets);
     }