mirror of
https://github.com/openai/codex.git
synced 2026-11-19 23:05:23 +00:00
Enable MCP user verification in the TUI (#43712)
## Why The TUI automatically canceled MCP user verification requests, preventing users from completing verification and approving them. ## What changed - Show verification prompts for active and inactive threads, with actions to verify and approve or cancel. - Run approved verification through the local app-server's `userVerification/verify` RPC and return the proof to the original request. Cancel on failure and show a warning in the requesting thread; remote workspaces remain unsupported. - Deduplicate prompts, preserve foreground streaming when another thread requests verification, and surface queued prompts when returning from a side conversation. - Cancel verification when its thread is discarded and ignore stale results after cancellation. ## Testing Add RPC, routing, and snapshot tests covering successful verification, unsupported binaries and remote workspaces, cancellation and late proofs, prompt replay, side conversation switching, and foreground stream preservation. GitOrigin-RevId: 2ae12f47c443e17de25f4ec033f6078ac28b1e03
This commit is contained in:
1 parent
95327467c3
commit
c7f81afc19
23 files changed
+1060
-29
No files matched your search
@@ -67,6 +67,13 @@ impl App {
|
||||
}
|
||||
|
||||
match event {
|
||||
AppEvent::UserVerificationApproved { thread_id, server_name, request_id } => {
|
||||
Box::pin(self.start_user_verification(app_server, thread_id, server_name, request_id)).await?;
|
||||
}
|
||||
AppEvent::UserVerificationFinished { thread_id, server_name, request_id, attempt_id, result } => {
|
||||
// Keep this RPC future out of the event loop's stack frame.
|
||||
Box::pin(self.finish_user_verification(app_server, thread_id, server_name, request_id, attempt_id, result)).await?;
|
||||
}
|
||||
AppEvent::ReviewMisalignment(review) => {
|
||||
self.open_misalignment_review(tui, review);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user