mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Route MCP elicitations through the shared approval decision path (#43447)
## What changed - Use `decide_approval` for MCP elicitations, carrying the effective approval policy, reviewer, and synchronous-review requirement into the decision. - Preserve unsupported form and URL elicitations for user review. - Use `computer_use_review_required()` for review evidence, session policy, and turn metadata so model policy takes precedence over the legacy flag. - Derive strict-review notifications from each assessment's review reason. ## Testing Add coverage for model policy precedence, user and full-access modes, sensitive elicitations, independent code-mode and nested-tool policies, cached score reuse, and user review of unsupported elicitations. GitOrigin-RevId: d0a9c40572dca7b3dbf876230d2162b72728084d
This commit is contained in:
1 parent
c0b6285711
commit
ce5c4133bd
12 files changed
+585
-129
No files matched your search
@@ -17,9 +17,9 @@ use crate::session::session::Session;
|
||||
/// This lets the extension return AskUser before invoking that renderer.
|
||||
#[derive(Clone)]
|
||||
pub(crate) struct ReviewAction {
|
||||
pub(super) action: Result<serde_json::Value, String>,
|
||||
pub(super) category: codex_protocol::openai_models::GuardianScope,
|
||||
pub(super) request: Result<GuardianApprovalRequest, String>,
|
||||
pub(crate) action: Result<serde_json::Value, String>,
|
||||
pub(crate) category: codex_protocol::openai_models::GuardianScope,
|
||||
pub(crate) request: Result<GuardianApprovalRequest, String>,
|
||||
}
|
||||
|
||||
impl From<GuardianApprovalRequest> for ReviewAction {
|
||||
|
||||
Reference in new issue
Block a user