mirror of
https://github.com/openai/codex.git
synced 2026-11-13 14:46:14 +00:00
fix(app-server): fix optional bool annotations (#24099)
`#[serde(default)]` wasn't sufficient for our generated TS types to reflect that clients didn't have to set them. We also need `skip_serializing_if = "std::ops::Not::not"`. This is already a rule in our agents.md file.
This commit is contained in:
1 parent
014f19af5f
commit
cff960896c
16 files changed
+31
-32
No files matched your search
@@ -14,6 +14,7 @@ pub struct FeedbackUploadParams {
|
||||
pub reason: Option<String>,
|
||||
#[ts(optional = nullable)]
|
||||
pub thread_id: Option<String>,
|
||||
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
|
||||
pub include_logs: bool,
|
||||
#[ts(optional = nullable)]
|
||||
pub extra_log_files: Option<Vec<PathBuf>>,
|
||||
|
||||
Reference in new issue
Block a user