mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Clean up side conversations in the background (#35887)
## Why Switching away from a side conversation should not wait for its interrupt and unsubscribe requests to finish. ## What changed - Remove a side conversation from local TUI state immediately when switching threads, then interrupt and unsubscribe it in a background task. - Retry interruption with the active turn ID when the original turn races with cleanup. - Ignore late notifications and reject server requests for abandoned side conversations. ## Testing - Added coverage that background cleanup removes local state and ignores late events and approval requests. GitOrigin-RevId: 7a1d1c34f16ab023d1d1e235451b55404731190c
This commit is contained in:
1 parent
b96ebfb312
commit
d06c7ac055
6 files changed
+148
-11
No files matched your search
@@ -954,6 +954,9 @@ impl App {
|
||||
thread_id: ThreadId,
|
||||
notification: ServerNotification,
|
||||
) -> Result<()> {
|
||||
if self.abandoned_side_threads.contains(&thread_id) {
|
||||
return Ok(());
|
||||
}
|
||||
if matches!(notification, ServerNotification::ThreadSettingsUpdated(_))
|
||||
&& self.primary_thread_id.is_some()
|
||||
&& self.primary_thread_id != Some(thread_id)
|
||||
|
||||
Reference in new issue
Block a user