mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Remove legacy Guardian approval review paths (#43462)
## What changed - Remove the `fast_decision` and `full_review` extension hooks and `ApprovalAssessment`, leaving `ApprovalReviewContributor::decide` as the approval decision interface. - Remove the duplicate Guardian V2 fast-approval implementation and `StrictReviewReason` state. - Require an explicit `GuardianReviewReason` for synchronous reviews. ## Testing Migrate Guardian reviewer tests to the production `decide_approval` path and cached-score tests to the registry's decision interface. GitOrigin-RevId: 1f9092c0ff5bb1eed0c63fa557fb3807e2e71564
This commit is contained in:
1 parent
8260619cb6
commit
db0568dbbb
14 files changed
+342
-968
No files matched your search
@@ -89,6 +89,6 @@ impl SynchronousApprovalReviewer for ReviewRuntime {
|
||||
&self,
|
||||
reason: codex_protocol::approvals::GuardianReviewReason,
|
||||
) -> ExtensionFuture<'_, ReviewDecision> {
|
||||
Box::pin(run_synchronous_review(self.clone(), Some(reason)))
|
||||
Box::pin(run_synchronous_review(self.clone(), reason))
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user