mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Use the async stack budget for approval reviews (#41840)
## What changed - Define the shared 16 MiB thread stack budget in `codex-async-utils`. - Use it for both the async main/runtime threads and the dedicated approval-review thread. GitOrigin-RevId: c825669e1545bcfaeaaaa07066dc63874f46630f
This commit is contained in:
1 parent
d58d0e5841
commit
e45226e771
5 files changed
+10
-3
No files matched your search
@@ -5,6 +5,7 @@ use codex_analytics::GuardianReviewFailureReason;
|
||||
use codex_analytics::GuardianReviewTerminalStatus;
|
||||
use codex_analytics::GuardianReviewTrackContext;
|
||||
use codex_analytics::GuardianReviewedAction;
|
||||
use codex_async_utils::THREAD_STACK_SIZE_BYTES;
|
||||
use codex_core_plugins::PluginCommandAttribution;
|
||||
use codex_extension_api::ThreadIdleCause;
|
||||
use codex_features::Feature;
|
||||
@@ -806,6 +807,7 @@ pub(crate) fn spawn_approval_request_review(
|
||||
let runtime = session.services.runtime_handle.clone();
|
||||
let spawn_result = std::thread::Builder::new()
|
||||
.name("codex-approval-review".to_string())
|
||||
.stack_size(THREAD_STACK_SIZE_BYTES)
|
||||
.spawn(move || {
|
||||
let decision = runtime.block_on(run_guardian_review(
|
||||
session, context, review_id, request, reasons, options,
|
||||
|
||||
Reference in new issue
Block a user