mirror of
https://github.com/openai/codex.git
synced 2026-11-16 06:54:36 +00:00
Decouple session isolation from subagent attribution (#44521)
## Why Session isolation relied on Guardian source attribution. An explicit policy lets callers control inherited capabilities independently of how a session is attributed. ## What changed - Add `SessionIsolation` with default `Inherit` and opt-in `Isolated` modes, captured at session startup through `ExtensionDataInit`. - Use the policy to control inherited instructions, extensions, execution rules, and MCP resources. Isolated sessions retain managed execution rules and omit executor-discovered MCP servers. - Explicitly isolate Guardian reviewers while preserving source-based fallback for older callers and saved reviewers. ## Testing Extend delegate tests to cover isolation independently of attribution, update execution-policy coverage to supply the explicit policy, and assert that managed reviewers do not inherit the parent's configured MCP tools. GitOrigin-RevId: f0ab42fa2f0237860ec661e72693ab191216afbf
This commit is contained in:
1 parent
9688359977
commit
ed6dde9fda
14 files changed
+83
-18
No files matched your search
@@ -128,6 +128,7 @@ impl ReviewerSessionFactory for PreparedSession {
|
||||
self.context.environments().clone(),
|
||||
cancellation.clone(),
|
||||
SubAgentSource::Other(GUARDIAN_REVIEWER_NAME.to_owned()),
|
||||
codex_extension_api::SessionIsolation::Isolated,
|
||||
initial_history,
|
||||
GitEnrichmentPolicy::Skip,
|
||||
codex_sandboxing::WindowsSandboxProxySettingsMode::Preserve,
|
||||
|
||||
@@ -67,7 +67,10 @@ impl ManagedReviewerThreads {
|
||||
config.permissions.approval_policy = Constrained::allow_only(AskForApproval::Never);
|
||||
config.model_provider.supports_websockets &=
|
||||
parent.services.model_client.responses_websocket_enabled();
|
||||
let mut thread_extension_init = codex_extension_api::ExtensionDataInit::default();
|
||||
thread_extension_init.insert(codex_extension_api::SessionIsolation::Isolated);
|
||||
let options = StartThreadOptions {
|
||||
thread_extension_init,
|
||||
session_source: Some(SessionSource::Internal(InternalSessionSource::Guardian)),
|
||||
thread_source: Some(ThreadSource::GuardianReview),
|
||||
environments: Some(context.environments().to_selections()),
|
||||
|
||||
Reference in new issue
Block a user