mirror of
https://github.com/openai/codex.git
synced 2026-11-18 23:02:23 +00:00
Notify clients when Guardian requires strict review (#39157)
## What changed - Add the experimental `autoApprovalReview/strictReviewRequired` app-server notification with the review's `threadId`, `turnId`, and `startedAtMs`. - Emit it when Guardian v2 leaves an approval review in progress because the action risk is elevated or its score is stale. - Export the notification through the Rust, TypeScript, and JSON schema surfaces and route it to the associated thread. ## Testing - Cover strict-review reason tracking for elevated and stale risk scores. - Verify that high-risk approval routing emits one notification whose identifiers and timestamp match the review-started event. GitOrigin-RevId: e65352894520bfb756c75b2c95e2e149f9767bb2
This commit is contained in:
1 parent
f6ba9110fa
commit
f5e9d66851
20 files changed
+258
-6
No files matched your search
@@ -1824,6 +1824,8 @@ server_notification_definitions! {
|
||||
ItemStarted => "item/started" (v2::ItemStartedNotification),
|
||||
ItemGuardianApprovalReviewStarted => "item/autoApprovalReview/started" (v2::ItemGuardianApprovalReviewStartedNotification),
|
||||
ItemGuardianApprovalReviewCompleted => "item/autoApprovalReview/completed" (v2::ItemGuardianApprovalReviewCompletedNotification),
|
||||
#[experimental("autoApprovalReview/strictReviewRequired")]
|
||||
StrictReviewRequired => "autoApprovalReview/strictReviewRequired" (v2::StrictReviewRequiredNotification),
|
||||
ItemCompleted => "item/completed" (v2::ItemCompletedNotification),
|
||||
/// This event is internal-only. Used by Codex Cloud.
|
||||
RawResponseItemCompleted => "rawResponseItem/completed" (v2::RawResponseItemCompletedNotification),
|
||||
|
||||
@@ -35,6 +35,17 @@ pub struct GuardianWarningNotification {
|
||||
pub message: String,
|
||||
}
|
||||
|
||||
#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
#[ts(export_to = "v2/")]
|
||||
pub struct StrictReviewRequiredNotification {
|
||||
pub thread_id: String,
|
||||
pub turn_id: String,
|
||||
/// Unix timestamp (in milliseconds) when this review started.
|
||||
#[ts(type = "number")]
|
||||
pub started_at_ms: i64,
|
||||
}
|
||||
|
||||
#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
#[ts(export_to = "v2/")]
|
||||
|
||||
Reference in new issue
Block a user