github/codex
4
0 Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-13 14:46:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Propagate updated permissions to review threads (#36901)

Browse Source 
## What changed

- Apply the session's current approval policy whenever per-turn configuration is built.
- Have review threads inherit the parent turn's full permission settings and approval reviewer.
- Add coverage for settings updated after session startup, including the approval policy, permission profile, and approval reviewer.

GitOrigin-RevId: bff050c6de157dd65d62f7b49651bef3f426ee3f
This commit is contained in:
jif authored and copyberry committed 2026-08-04 14:29:24 +00:00
1 parent 18f03c1eb7
commit f93109615f
5 files changed
+116 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

codex-rs/core/src/session/turn_context.rs
+1 -1
View File
@@ -440,6 +440,7 @@ impl Session {
let config = session_configuration.original_config_do_not_use.clone();
let mut per_turn_config = (*config).clone();
per_turn_config.cwd = cwd;
per_turn_config.permissions.approval_policy = session_configuration.approval_policy.clone();
let workspace_roots = session_configuration.primary_workspace_roots();
per_turn_config.workspace_roots = workspace_roots.clone();
per_turn_config
@@ -478,7 +479,6 @@ impl Session {
let mut config =
Self::build_per_turn_config(session_configuration, session_configuration.cwd().clone());
config.model = Some(session_configuration.collaboration_mode.model().to_string());
config.permissions.approval_policy = session_configuration.approval_policy.clone();
config
}